Attest the ranked projects inside a category.

[MoeNick]

As a user, after I finish voting a Pairwise ranking and before I have been sent back to the categories page, I want to cast my vote on-chain by an attestation.

Design:

https://www.figma.com/design/tP7Arb2C8aDB05wCVxVVSB/Pairwise-RF6--%3E-Voting-App?node-id=1175-35870&t=vkHFl1L2Am6QdxHX-4

Success Criteria

• 1- The user clicks on submit vote after they've done the rankings.
• 2- The user sees a loading and Dapp is doing attestations in the background.
• 3- When it’s done we can show them a link to attestations.
• 4- By clicking on OK/Close user will get back to the categories page with the category status change to voted
• 5- The attestation should be submitted by the AA address, with the ranking of all projects with percentages.
• 6- The attestation should not have the user weight/role but have a hash to calculate the rankings at the end of the round.
• 7- for reporting error on error modal, use this link that opens in a new tab: https://github.com/GeneralMagicio/pairwise-rf6/issues/new?assignees=MoeNick&labels=bug&projects=&template=error-submit-vote.md&title=%5BError+submit+vote%5D+

NOTE: if the user has not voted on a category yet, logging in with an email modal is required.

[MoeNick]

@mmahdigh I updated the issue.
@Meriem-BM you can ask @mmahdigh to take care of the last step in pairwise comparisons.

[MoeNick]

@mmahdigh I provided the link to the error attesting your vote as 7th success criteria.

[maryjaf]

By tapping on submit vote, I got an error @mmahdigh

Payload:

[mmahdigh]

By tapping on submit vote, I got an error @mmahdigh

Payload:

Can you retest it now? The summation of your shares is 99.97% that's why our backend was declining it. I lowered the sensitivity for now.

[mmahdigh]

By tapping on submit vote, I got an error @mmahdigh

Payload:

@Meriem-BM Could you take a look and investigate why is the summation 99.97%? My guess is that you're cutting share numbers to 4 decimal places (see the payload) and that's why we're short 0.03%. Let's keep at least 6 decimal places and only for the sake of showing the number in the input, show them rounded to 4 decimal places.

Let me know if it's something else or unavoidable.

[maryjaf]

By tapping on submit vote, I got an error @mmahdigh

Payload:

Can you retest it now? The summation of your shares is 99.97% that's why our backend was declining it. I lowered the sensitivity for now.

---

Screen.Recording.2024-10-28.at.4.38.09.PM.mov

Screen.Recording.2024-10-28.at.4.36.19.PM.mov

[mmahdigh]

By tapping on submit vote, I got an error @mmahdigh

Payload:

Can you retest it now? The summation of your shares is 99.97% that's why our backend was declining it. I lowered the sensitivity for now.

Screen.Recording.2024-10-28.at.4.38.09.PM.mov
Screen.Recording.2024-10-28.at.4.36.19.PM.mov

Would you please give me your wallet address?

[maryjaf]

0xA1179f64638adb613DDAAc32D918EB6BEB824104 @mmahdigh

[mmahdigh]

0xA1179f64638adb613DDAAc32D918EB6BEB824104 @mmahdigh

Okay, It was a bug in calculating progress and finishing collections automatically. You gamed the system by giving every project a 1-star 😆

I reduced the number of comparisons for the time being so you can get to the end of comparisons faster.

I think you can successfully finish the attestation flow now.

[MoeNick]

@mmahdigh if you merge the @Meriem-BM PR then we test again

[mmahdigh]

She hasn't asked for a review yet. @MoeNick

[maryjaf]

Thanks @Meriem-BM @mmahdigh
This problem has been fixed

[maryjaf]

a new problem happens in attest flow @mmahdigh
when I submit vote, in allocation page I see the status of this category remains "vote" and it isn't changed to voted

https://github.com/user-attachments/assets/d6440d54-9293-4639-88a9-dc8691608b5a
https://github.com/user-attachments/assets/cdd6e0a5-ad78-4c9f-96f1-152383fa293e

[maryjaf]

a new problem happens in attest flow @mmahdigh when I submit vote, in allocation page I see the status of this category remains "vote" and it isn't changed to voted

https://github.com/user-attachments/assets/d6440d54-9293-4639-88a9-dc8691608b5a https://github.com/user-attachments/assets/cdd6e0a5-ad78-4c9f-96f1-152383fa293e

Thanks @Meriem-BM This problem has been fixed
But there is another issue , please take a look

• If I tap on "back to category" before tapping on submit vote , in this page I see the status is change to voted and there is view attestation option
  @Meriem-BM

[maryjaf]

• By tapping on "View attestation" link in allocation page, nothing happens @Meriem-BM

Screen.Recording.2024-10-30.at.2.23.59.PM.mov

[Meriem-BM]

• By tapping on "View attestation" link in allocation page, nothing happens @Meriem-BM

Screen.Recording.2024-10-30.at.2.23.59.PM.mov

@mmahdigh Do you know what should be triggered here? I haven't added anything yet, as well as for the Delegate button next to the budget bar.

[Meriem-BM]

• If I tap on "back to category" before tapping on submit vote , in this page I see the status is change to voted and there is view attestation option

The View attestation should be shown when collection is attested? we have two status Finished (done voting) and Attested, if you can tell me what should we show for each? @MoeNick

[MoeNick]

• If I tap on "back to category" before tapping on submit vote , in this page I see the status is change to voted and there is view attestation option

The View attestation should be shown when collection is attested? we have two status Finished (done voting) and Attested, if you can tell me what should we show for each? @MoeNick

Yes when attested we have attested status and we show the link.
Budget is a bit different as it does not have finished status
Finished is for category ranking, when the comparisons are done, but user did not click on attest yet. even in this case, the category is not voted and we cant have attestation link.
@Meriem-BM @mmahdigh

[Meriem-BM]

Can you test these @maryjaf

[maryjaf]

• If I tap on "back to category" before tapping on submit vote , in this page I see the status is change to voted and there is view attestation option

The View attestation should be shown when collection is attested? we have two status Finished (done voting) and Attested, if you can tell me what should we show for each? @MoeNick

Yes when attested we have attested status and we show the link. Budget is a bit different as it does not have finished status Finished is for category ranking, when the comparisons are done, but user did not click on attest yet. even in this case, the category is not voted and we cant have attestation link. @Meriem-BM @mmahdigh

this is ready for testing @Meriem-BM or only attest link ?

[maryjaf]

I haven't seen finished status for category, after completing ranking and before submitting vot I see below view
@Meriem-BM

[Meriem-BM]

I haven't seen finished status for category, after completing ranking and before submitting vot I see below view @Meriem-BM

We didn't have that on the Figma designs, @MoeNick, should I add a status for case when comparison is done?

[MoeNick]

I haven't seen finished status for category, after completing ranking and before submitting vot I see below view @Meriem-BM

No we SHOULD NOT have finished status in UI, it's only voted. my comments was for backedn and finished / attested meaning.
We only have voted or vote in UI which means attested / not yet attested
@maryjaf @Meriem-BM

[MoeNick]

In above picture we should have Vote Button with Voting status. For Governance Leadership
means when user clicks, they can resume to edit / attest flow

[maryjaf]

In above picture we should have Vote Button with Voting status. means when user clicks, they can resume to edit / attest flow

@Meriem-BM

[Meriem-BM]

@maryjaf you can test this one

[maryjaf]

I couldn't complete the submit vote flow because of this
#6 (comment)

[maryjaf]

In above picture we should have Vote Button with Voting status. For Governance Leadership means when user clicks, they can resume to edit / attest flow

It hasn't been fixed : @Meriem-BM

Screen.Recording.2024-10-31.at.12.07.22.AM.mov

[Meriem-BM]

In above picture we should have Vote Button with Voting status. For Governance Leadership means when user clicks, they can resume to edit / attest flow

It hasn't been fixed : @Meriem-BM

Screen.Recording.2024-10-31.at.12.07.22.AM.mov

What's the status of that category @maryjaf? if it's done with comparison, then that's expected before it's attested. @MoeNick told me to redirect to last comparison and show that modal.

[maryjaf]

In above picture we should have Vote Button with Voting status. For Governance Leadership means when user clicks, they can resume to edit / attest flow

it's done with comparison(but not attested) and base on above comment the status should be voting and vote button should be shown

current behavior :

Screen.Recording.2024-10-31.at.8.52.04.PM.mov

@Meriem-BM @MoeNick

[Meriem-BM]

In above picture we should have Vote Button with Voting status. For Governance Leadership means when user clicks, they can resume to edit / attest flow

it's done with comparison(but not attested) and base on above comment the status should be voting and vote button should be shown

current behavior :

Screen.Recording.2024-10-31.at.8.52.04.PM.mov
@Meriem-BM @MoeNick

Got it, my bad, I should keep the voting status

[Meriem-BM]

@maryjaf can you check this please

[maryjaf]

Thanks @Meriem-BM

current behavior :
cc: @MoeNick