Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalogue Support/Missing Type #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Catalogue Support/Missing Type #47

wants to merge 3 commits into from

Conversation

ChaosDogG
Copy link
Contributor

Should have Catalogue mod by MrCrayfish use Generation's icon

@ChaosDogG ChaosDogG changed the title Catalogue Support Catalogue Support/Missing Type Aug 15, 2024
JT122406
JT122406 requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@JT122406 JT122406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These Tags are Datagenned and should be done in code and not manually made jsons

@ChaosDogG
Copy link
Contributor Author

I see, i will figure out how to fix that in the morning

@ChaosDogG
Copy link
Contributor Author

Or rather, when i get the chance tomorrow

@Dysth
Copy link
Contributor

Dysth commented Nov 9, 2024

checking in on this, can do it ourselves shortly if you need us to since this contains valid bug fixes

@ChaosDogG
Copy link
Contributor Author

that'd b awesome, thanks!

@ChaosDogG
Copy link
Contributor Author

i also forgor to add silicon to a tag as well, should b forge:silicon iirc

Waterpicker added a commit that referenced this pull request Mar 4, 2025
@Waterpicker
Manually copying over #47 Mr Crayfish's Catalogue support.
4af2041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JT122406 JT122406 JT122406 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaosDogG @Dysth @JT122406