-
Notifications
You must be signed in to change notification settings - Fork 401
Fix psmeca failure when P and T axes have equal dips #8862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug in the psmeca module where the function failed when the P (pressure) and T (tension) axes have equal dips. The fix modifies the logic in the meca_axe2dc function to properly handle the edge case of equal dips while excluding the strike-slip fault case.
Key changes:
- Enhanced conditional logic to detect when P and T axes have equal dips (within tolerance)
- Added special handling to exclude strike-slip faults where both dips are near zero
- Added explanatory comments documenting the logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joa-quim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI continue a incomprehensible disaster. Run the tests locally and and all seem fine. Two points though:
- We use C comments, not C++ (Copilot invention)
- What about a new test for this case?
|
Looks good. Could you please add a test for it? |
Ok,I'll be careful next time. |
I'll try to add one if I can |
You can still change it for this time. It's just replace the |
|
Could you please also add the focal mechanisms in #8009 into the test? |
I tried again, however, unlike before, I was able to download the dvc files during this local test, so I used the results from the master branch for the test.
Fixes #8009