Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZH-261 - Add Node-specific SOP: NCPs veto EDIC decision #32

Merged
merged 10 commits into from
Oct 4, 2024
Merged

Conversation

M-casado
Copy link
Collaborator

@M-casado M-casado commented Sep 27, 2024

Summary

Addition of the Node-specific SOP NCPs veto EDIC decision

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Motivation and Context

SOP was ready to be added to the GH repo after internal reviews.

References

ZenHub #261

Changes Introduced

  • Addition of new SOP NCPs veto EDIC decision at sops/node-specific/GDI-SOP0002_NCPs-veto-EDIC-decision.md
  • Addition of image related to SOP

Review

It was reviewed internally to T4.3, and also by Regina Becker.

Additional Notes

NA

Checklist:

General Compliance:

  • My changes follow the code style of this project (GDI SOP Style Guide) and the file naming conventions of the file accessioning proposal.
  • I have verified that all new updated content is accessible, including checking that all external references are readable (i.e., no broken links). These may include references to external resources that should be resolvable, and internal references among SOPs.
  • I have properly added this PR's changes to the repository CHANGELOG.md.

Only applicable if the PR includes new, or changes to, GDI SOPs (i.e., documents at sops/):

  • My SOP-related changes adhere to the Generic SOP Template, including format and required fields.
  • I have consulted the Charter, ISM, and ORR documents to ensure compliance.
  • I am complying with the established procedure for SOP creations and modifications, including respecting review phases and notifying needed contributors for reviews.

@M-casado
Copy link
Collaborator Author

Important for all reviewers and especially @jdylan: I not only transformed the document to markdown, I also added a few modifications to the procedures, for clarity. To ease the review, focus on this commit, which contains all new additions (in content, not just format) to the procedure of the SOP.

@M-casado
Copy link
Collaborator Author

M-casado commented Sep 27, 2024

Reminder for the future:

  • Add the Approver/Authorizers once to be merged with dev

Copy link
Contributor

@GabiRinck GabiRinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process looks well thought through.
I've added a few minor comments that may help with clarity in a couple of places.
Many thanks!

Copy link

@jmenglund jmenglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. The document is probably good enough for now!

@M-casado M-casado merged commit 69e4b11 into dev Oct 4, 2024
2 checks passed
@M-casado M-casado deleted the ZH-261 branch October 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants