Skip to content

Conversation

dsuren1
Copy link

@dsuren1 dsuren1 commented Sep 23, 2025

Description

This PR refactors the create dataset page and attribute table validation to include restrictions and enumerations

Issue

@dsuren1 dsuren1 added this to the 5.0.0 milestone Sep 23, 2025
@dsuren1 dsuren1 self-assigned this Sep 23, 2025
@dsuren1 dsuren1 added the enhancement New feature or request label Sep 23, 2025
@dsuren1 dsuren1 linked an issue Sep 23, 2025 that may be closed by this pull request
Copy link

Summary of Changes

Hello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly overhauls the dataset creation experience by refactoring the dedicated page and enhancing attribute validation capabilities. It introduces a new plugin that allows users to define detailed restrictions and enumerations for dataset attributes, ensuring data integrity from the outset. The changes include new UI components, robust validation logic, updated routing, and comprehensive localization, making the dataset creation process more guided and error-resistant.

Highlights

  • Refactored Create Dataset Page: The entire 'create dataset' page has been refactored, introducing a new, more robust interface for defining dataset attributes.
  • Enhanced Attribute Table Validation: Attribute table validation now includes support for defining restrictions such as ranges (min/max values) and enumerations (predefined options) for various attribute types.
  • New CreateDataset Plugin: A new CreateDataset plugin has been introduced, encapsulating the logic and UI for the dataset creation process, including attribute management and validation.
  • Updated Routing and UI Integration: The application's routing has been updated to include a dedicated path for the new dataset creation page, and UI styling has been adjusted to ensure a consistent look and feel.
  • Comprehensive Attribute Validation Utilities: New utility functions and a JSON schema have been added to provide client-side validation for dataset attributes, covering unique names, valid ranges, and required fields, with custom error messages.
  • Localization Support: New localization strings have been added across multiple languages to support the new UI elements and validation messages introduced in the dataset creation process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new page for creating datasets from scratch, including defining attributes with types and restrictions. The implementation is well-structured, using React components and a JSON schema for validation. The code is generally of high quality, with good separation of concerns between UI components, containers, and utility functions. I've included a few suggestions to improve maintainability and adhere to modern React best practices, such as updating dependencies and using hooks. I also found a couple of issues in the validation schema that should be addressed for correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON Schema based configuration for create dataset page Refactor of the create dataset page and attribute table validation

1 participant