-
Notifications
You must be signed in to change notification settings - Fork 124
#2157: Refactor of the create dataset page and attribute table validation #2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly overhauls the dataset creation experience by refactoring the dedicated page and enhancing attribute validation capabilities. It introduces a new plugin that allows users to define detailed restrictions and enumerations for dataset attributes, ensuring data integrity from the outset. The changes include new UI components, robust validation logic, updated routing, and comprehensive localization, making the dataset creation process more guided and error-resistant. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new page for creating datasets from scratch, including defining attributes with types and restrictions. The implementation is well-structured, using React components and a JSON schema for validation. The code is generally of high quality, with good separation of concerns between UI components, containers, and utility functions. I've included a few suggestions to improve maintainability and adhere to modern React best practices, such as updating dependencies and using hooks. I also found a couple of issues in the validation schema that should be addressed for correctness.
Description
This PR refactors the create dataset page and attribute table validation to include restrictions and enumerations
Issue