Fix: protect report endpoint from email failure #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when the confirmation email sending failed the endpoint answered with error 500.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3626 +/- ##
==========================================
- Coverage 98.31% 98.30% -0.01%
==========================================
Files 292 292
Lines 21567 21571 +4
==========================================
+ Hits 21203 21205 +2
- Misses 364 366 +2
☔ View full report in Codecov by Sentry. |
Passing run #6546 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when the confirmation email sending failed the endpoint answered with error 500 even though the report was correctly saved.