Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code filter in signage list #4534

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Add code filter in signage list #4534

merged 3 commits into from
Feb 21, 2025

Conversation

raphaeldoisy
Copy link
Contributor

Description

#4367

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (77dc71f) to head (fd4fd43).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4534   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         270      270           
  Lines       21522    21523    +1     
=======================================
+ Hits        21193    21194    +1     
  Misses        329      329

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Feb 20, 2025 •
edited
Loading

Geotrek-admin    Run #11252

Run Properties:  status check passed Passed #11252  •  git commit d71b623023 ℹ️: Merge fd4fd43226b9421228b2667edca271ec12135241 into 10e109e3d0a29ef6ee8fdf115af5...
Project Geotrek-admin
Branch Review refs/pull/4534/merge
Run status status check passed Passed #11252
Run duration 02m 10s
Commit git commit d71b623023 ℹ️: Merge fd4fd43226b9421228b2667edca271ec12135241 into 10e109e3d0a29ef6ee8fdf115af5...
Committer Raphael Doisy
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos
Copy link
Member

submarcos commented Feb 20, 2025 •
edited
Loading

une petite entrée dans le changelog et c'est tout bon

@submarcos submarcos marked this pull request as ready for review February 20, 2025 17:08
@submarcos submarcos changed the title 💫 [IMPR] Add code signage to filter Add code filter in signage list Feb 21, 2025
@submarcos submarcos merged commit d488b3c into master Feb 21, 2025
26 checks passed
@submarcos submarcos deleted the impr_filter_code_signage branch February 21, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@submarcos submarcos submarcos approved these changes

Assignees
No one assigned
Labels
💫 Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphaeldoisy @submarcos