Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection des utilisateurs après login #70 #81

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions backend/core/routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,18 @@ def get_portal_link(reservation):
return f"{protocol}{hostname}{front_path}?email={reservation.email}"


def get_login_link(token):
def get_login_link(token, redirect_to):
from flask import current_app

protocol = "http://" if current_app.config["DEBUG"] else "https://"
hostname = current_app.config["PUBLIC_SERVER_NAME"]
front_path = current_app.config["FRONTEND_LOGIN_PATHNAME"]
return f"{protocol}{hostname}{front_path}?token={token}"

route = f"{protocol}{hostname}{front_path}?token={token}"

if redirect_to:
route = f"{route}&route={redirect_to}"
return route


class QueryParamValidationError(Exception):
Expand Down Expand Up @@ -538,6 +543,7 @@ def cancel_reservation(reservation_id):
def send_login_email():
try:
email = request.get_json()["email"]
redirect_to = request.get_json().get("route", None)
except KeyError:
return jsonify({"error": "'email' property is mandatory"}), 400

Expand All @@ -551,11 +557,12 @@ def send_login_email():

db.session.add(token)
db.session.commit()

send_email(
get_mail_subject("Lien de connexion au site de réservation des animations"),
recipients=[email],
html=render_template("login_mail.html", login_link=get_login_link(token.token)),
html=render_template(
"login_mail.html", login_link=get_login_link(token.token, redirect_to)
),
)

return "lien de login envoyé", 204
Expand Down
3 changes: 3 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@

# Changelog

**🐛 Corrections**
- Redirection du formulaire d'inscription vers la page d'accueil si l'utilisateur n'est pas authentifié (#70).

## 0.4.0 (unreleased)

## 0.3.0 (2024-06-24)
Expand Down
19 changes: 14 additions & 5 deletions front-vite/src/router/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const routes = [
name: ROUTES_NAMES.RESA_FORM,
component: () => import('@/views/ReservationFormView.vue'),
meta: {
requiresAuth: false
requiresAuth: true
}
}, {
path: ROUTES_PATHS.RESA_LISTING,
Expand Down Expand Up @@ -151,17 +151,26 @@ router.beforeEach((to, from, next) => {
// we are going to a route that may require auth
if (to.meta.requiresAuth) {
// if user is not auth, go to login
// Store requested route
if (!authStore.isAuth) {
next({
path: ROUTES_PATHS.LOGIN,
replace: true,
authStore.requestedRoute(to.path as string)
if (to.name===ROUTES_NAMES.RESA_FORM) {
next({
path: ROUTES_PATHS.HOME,
replace: true,
});
} else {
next({
path: ROUTES_PATHS.LOGIN,
replace: true,
});
}
} else if (
to.meta.requiresAdmin &&
!authStore.isAdmin
){
// if the route need admin permission
// but user is not ad admin
// but user is not admin
// go to home page
next({
path: ROUTES_PATHS.HOME,
Expand Down
13 changes: 11 additions & 2 deletions front-vite/src/stores/auth.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ref, computed } from 'vue'
import { defineStore } from 'pinia'
import { postApiData, getApiData } from '@/utils/api'
import type { RouteRecordName } from 'vue-router'

interface User {
email: string
Expand All @@ -11,6 +12,12 @@ export const useAuthStore = defineStore('auth', () => {

const user = ref<null | User>(null)

const redirectTo = ref<null | string>(null)

function requestedRoute(route: string) {
redirectTo.value = route as string;
}

const isAuth = computed(() => {
return !!user.value
})
Expand Down Expand Up @@ -61,22 +68,24 @@ export const useAuthStore = defineStore('auth', () => {
/**
* Ask for sending a password-less email login to the user
*/
async function sendLoginEmail (email: string) {
async function sendLoginEmail(email: string) {
await postApiData(
CONFIGURATION.URL_APPLICATION,
'send-login-email',
{ email },
{ "email": email, "route": redirectTo.value }
)
}

return {
user,
isAuth,
isAdmin,
redirectTo,

checkAuth,
login,
logout,
sendLoginEmail,
requestedRoute
}
})
13 changes: 8 additions & 5 deletions front-vite/src/views/HomeView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,20 @@
</header>
<main class="mx-auto max-w-7xl py-6 sm:px-6 lg:px-8 px-4 py-6">
<section class="pb-12 mx-auto">
<p class="mb-8">
Bienvenue sur l'outil de gestion des réservations d'événement du {{ parkLabel }}.
</p>
<p class="mb-4">
Bienvenue sur l'outil de gestion des réservations d'événements du {{ parkLabel }}.
</p>
<p v-if="!authStore.isAuth">
Il est nécessaire de se connecter pour effectuer une réservation ou gérer vos inscriptions.
</p>

<p class="flex items-center">
<router-link
v-if="!authStore.isAuth"
to="/login"
class="rounded-sm bg-sky-600 px-3 py-1.5 text-sm font-medium leading-6 text-white shadow-sm hover:bg-sky-500 my-4 mx-auto"
class="rounded-sm bg-sky-600 px-3 py-1.5 text-sm font-medium leading-6 text-white shadow-sm hover:bg-sky-500 my-6 mx-auto"
>
Aller à la page de connexion
Se connecter
</router-link>
</p>

Expand Down
17 changes: 12 additions & 5 deletions front-vite/src/views/LoginCallbackView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { ref, onMounted } from 'vue'
import { ROUTES_PATHS } from '@/router'

const token = useRoute().query.token as string
const redirectTo = useRoute().query.route as string
const authStore = useAuthStore()
const router = useRouter()

Expand All @@ -46,14 +47,20 @@ onMounted(async () => {
await authStore.login(token)
success.value = true
/**
* Si l'utilisateur est admin, on le renvoie sur la page des événements
* Si le paramètre route est spécifié on le renvoie vers la page demandé sauf si login ou home
*/
if (authStore.isAdmin) {
if (redirectTo && ![ROUTES_PATHS.LOGIN, ROUTES_PATHS.HOME].includes(redirectTo)) {
router.push(redirectTo)
}
else if (authStore.isAdmin) {
/**
* Si l'utilisateur est admin, on le renvoie sur la page des événements
*/
router.push(ROUTES_PATHS.EVENT_LISTING)
} else {
/**
* Sinon, sur les réservations
*/
/**
* Sinon, sur les réservations
*/
router.push(ROUTES_PATHS.RESA_LISTING)
}
} catch {
Expand Down
7 changes: 6 additions & 1 deletion front-vite/src/views/LoginView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@
<div v-if="error" class="text-red-500">
Une erreur est survenue pendant la demande de votre lien de connexion.<br/>
Merci d'essayer à nouveau.<br/>
Si vous n'arrivez pas à obtenir le lien de connexion, merci de prendre contact avec le parc.
Si vous n'arrivez pas à obtenir le lien de connexion, merci de prendre contact avec le parc.
</div>
<div v-if="default_message">
La connexion est obligatoire pour pouvoir effectuer une réservation ou gérer vos inscriptions.
</div>
</form>
</div>
Expand All @@ -52,6 +55,7 @@ import { useRoute } from 'vue-router';
const loading = ref(false)
const success = ref(false)
const error = ref(false)
const default_message = ref(true)

const route = useRoute()
const email = ref(route.query.email as string)
Expand All @@ -67,6 +71,7 @@ async function login() {
} catch {
error.value = true
}
default_message.value = false
loading.value = false
}

Expand Down
13 changes: 12 additions & 1 deletion front-vite/src/views/ReservationFormView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@
@submit="saveReservation"
:saving="saving"
:save-error="saveError"
:original-values="resaToEdit || {}"
/>

</section>
Expand Down Expand Up @@ -134,7 +135,15 @@ import EventSummary from '@/components/EventSummary.vue'
import EventReservationForm from '@/components/EventReservationForm.vue'
import type { ResaEvent } from '@/declaration';
import { isReservationOpened, isReservationGloballyOpened } from '@/utils/isReservationOpened'
import type { Resa } from '@/declaration';
import { useAuthStore } from '@/stores/auth';
import { storeToRefs } from 'pinia'

const authStore = useAuthStore()
const { user } = storeToRefs(authStore)


const resaToEdit = ref<Resa | null>(null)
const currentRoute = useRoute()
const geotrekId = currentRoute.params.geotrekid

Expand Down Expand Up @@ -180,7 +189,9 @@ onBeforeMount(async () => {
default:
eventError.value = "Une erreur est survenue. Il est impossible d'effecuter une réservation. Merci de prendre contact avec le parc."
}
}
}
// Prefil email
resaToEdit.value = { email: user.value?.email } as Resa
loadingEvent.value = false
})

Expand Down
Loading