Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated data dictionary widget functional test to test all fields in the form and the data dictionary and index field displays. #4265

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Updated data dictionary widget functional test to test all fields in the form and the data dictionary and index field displays. #4265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 75 additions & 1 deletion modules/data_dictionary_widget/tests/src/Functional/DataDictionaryWidgetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class DataDictionaryWidgetTest extends BrowserTestBase {
* Test the behavior of the Data-Dictionary-Widget.
*/
public function testDataDictionaryWidgetBehavior() {
$permissions = ['administer data dictionary settings', 'create data content', 'administer site configuration', 'administer content types', 'bypass node access'];
$permissions = ['administer data dictionary settings', 'create data content', 'administer site configuration', 'administer content types', 'bypass node access', 'use dkan_publishing transition publish'];
$this->drupalLogin($this->drupalCreateUser($permissions));
$session = $this->assertSession();

Expand All @@ -53,6 +53,80 @@ public function testDataDictionaryWidgetBehavior() {
$session->elementExists('css', '#edit-field-json-metadata-0-dictionary-fields-add-row-button');
$session->elementExists('css', '#edit-field-json-metadata-0-indexes-add-row-button');

$page = $this->getSession()->getPage();

// Title is not hidden, so we have to fill it some data.
$page->fillField('title[0][value]', 'Test Data Set');

// Fill the actual data dictionary title.
$test_data_dictionary_title = 'Test Data Dictionary';
$page->fillField('field_json_metadata[0][title]', $test_data_dictionary_title);

// Fill the data dictionary fields.
$page->pressButton('Add field');
$test_data_dictionary_field_name = 'test';
$test_data_dictionary_field_title = 'Test Title';
$test_data_dictionary_field_type = 'string';
$test_data_dictionary_field_format = 'default';
$test_data_dictionary_field_description = 'Test Description';
$page->fillField('field_json_metadata[0][dictionary_fields][field_collection][group][name]', $test_data_dictionary_field_name);
$page->fillField('field_json_metadata[0][dictionary_fields][field_collection][group][title]', $test_data_dictionary_field_title);
$page->selectFieldOption('field_json_metadata[0][dictionary_fields][field_collection][group][type]', $test_data_dictionary_field_type);
$page->selectFieldOption('field_json_metadata[0][dictionary_fields][field_collection][group][format]', $test_data_dictionary_field_format);
$page->fillField('field_json_metadata[0][dictionary_fields][field_collection][group][description]', $test_data_dictionary_field_description);
$page->pressButton('Add');

// Assert the values are being displayed.
$session->pageTextContains($test_data_dictionary_field_name);
$session->pageTextContains($test_data_dictionary_field_title);
$session->pageTextContains('Data Type: ' . $test_data_dictionary_field_type);
$session->pageTextContains('Format: ' . $test_data_dictionary_field_format);
$session->pageTextContains('Description: ' . $test_data_dictionary_field_description);

// Edit data dictionary fields and confirm fields have the same values.
$page->pressButton('Edit');
$session->fieldValueEquals('field_json_metadata[0][dictionary_fields][data][0][field_collection][name]', $test_data_dictionary_field_name);
$session->fieldValueEquals('field_json_metadata[0][dictionary_fields][data][0][field_collection][title]', $test_data_dictionary_field_title);
$session->fieldValueEquals('field_json_metadata[0][dictionary_fields][data][0][field_collection][type]', $test_data_dictionary_field_type);
$session->fieldValueEquals('field_json_metadata[0][dictionary_fields][data][0][field_collection][format]', $test_data_dictionary_field_format);
$session->elementTextContains('css', 'textarea[name="field_json_metadata[0][dictionary_fields][data][0][field_collection][description]"]', $test_data_dictionary_field_description);
$page->pressButton('Cancel');

// Fill the indexes fields.
$page->pressButton('Add index');
$test_index_title = 'Test Index';
$test_index_type = 'index';
$test_index_name = 'test_index';
$test_index_length = 20;
$page->fillField('field_json_metadata[0][indexes][field_collection][group][index][description]', $test_index_title);
$page->selectFieldOption('field_json_metadata[0][indexes][field_collection][group][index][type]', $test_index_type);
// Add an index field.
// Use the name to distinguish the button from the data dictionary fields.
$page->pressButton('add_index_field');
$page->fillField('field_json_metadata[0][indexes][fields][field_collection][group][index][fields][name]', $test_index_name);
$page->fillField('field_json_metadata[0][indexes][fields][field_collection][group][index][fields][length]', $test_index_length);
// Need to distinguish the add button on the index fields vs the one for data dictionary fields.
$page->pressButton('Add ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd that this has a space after but good that it allows for a distinguishment between the two, we should probably make this more unique in later iterations, something like "add new index field".

$page->pressButton('Submit Index');

// Assert the values are being displayed.
$session->pageTextContains($test_index_title);
$session->pageTextContains($test_index_type);
$session->pageTextContains('Field Name: ' . $test_index_name);
$session->pageTextContains('Field Length: ' . $test_index_length);

// Edit index and confirm fields have the same values.
$page->pressButton('Edit index');
$session->fieldValueEquals('field_json_metadata[0][indexes][edit_index][index_key_0][description]', $test_index_title);
$session->fieldValueEquals('field_json_metadata[0][indexes][edit_index][index_key_0][type]', $test_index_type);
$session->pageTextContains($test_index_name);
$session->pageTextContains($test_index_length);
$page->pressButton('Cancel Index');

// Save the data dictionary.
$page->pressButton('Save');

$session->pageTextContains($test_data_dictionary_title);
}

}