Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix proto breaking change #843

Merged
merged 1 commit into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@ PB=$REPO/protobuf

export PATH=/opt/.protoc/bin:$PWD/.protoc/bin:$PATH

REALPATH=${REALPATH:-$(if [[ "$OSTYPE" == "darwin"* ]]; then echo "grealpath"; else echo "realpath"; fi)}
if ! command -v $REALPATH &> /dev/null; then
echo "$REALPATH command not found. Please install it and try again."
exit 1
fi
# In some systems like Mac OS 13.0.1, the realpath defaults to
# the system installed one which does not support flags like
# --relative-path. This results in the scripts erroring out.
# The coreutils installed with Homebrew (as mentioned in README)
# installs GNU realpath which could be available as "grealpath"
# which actually works. Hence, the option to customize REALPATH
REALPATH=${REALPATH:-realpath}

GEN_PROFILE=${1:-go}

Expand Down
9 changes: 2 additions & 7 deletions protobuf/video/sfu/models/models.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion protobuf/video/sfu/models/models.proto
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ message PublishOption {
}

message Codec {
uint32 payload_type = 13;
uint32 payload_type = 16;
string name = 10;
uint32 clock_rate = 14;
string encoding_parameters = 15;
Expand Down
56 changes: 29 additions & 27 deletions protobuf/video/sfu/models/models_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading