feat: add support for global modal rendering at the top of the chat component tree #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6.17 kB (+0.55%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2792 +/- ##
==========================================
+ Coverage 81.21% 81.30% +0.08%
==========================================
Files 487 488 +1
Lines 9785 9900 +115
Branches 2215 2246 +31
==========================================
+ Hits 7947 8049 +102
- Misses 1728 1740 +12
- Partials 110 111 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oliverlaz
approved these changes
Aug 8, 2025
|
🎉 This PR is included in version 13.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow to render the modal at the top of chat app.
Fixes REACT-22
Fixes REACT-340
Fixes the issue of modal overlay being cut-off in Safari because the parent was the message thus limiting the overlay position fixed to the message list.
Depends on CSS adjustments: GetStream/stream-chat-css#341
This is an opt-in feature. The top-level modal rendering is activated by passing
GlobalModaltoChanneland thus theComponentContext:🛠 Implementation details
The PR introduces possibility of nested
DialogManagerProviders(Modal > MessageList) and thus allowing to retrieve a dialog manager other than the one from the nearest dialog manager context.🎨 UI Changes
None
Docs
https://github.com/GetStream/docs-content/pull/519