Added /exec and /proj arguments #112
Conversation
|
This is good to go again @andreasohlund @SimonCropp |
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{3EFFC5D6-88D0-49D9-BB53-E1B7EB49DD45}" | ||
| ProjectSection(SolutionItems) = preProject | ||
| LICENSE = LICENSE | ||
| README.md = README.md |
There was a problem hiding this comment.
why do we need these as solution items?
There was a problem hiding this comment.
Mainly so readme is easily accessed so it gets updated when things are changed. Happy to revert though
There was a problem hiding this comment.
nah that is fine. was just curious
|
dont like approval tests? |
| @@ -8,6 +8,8 @@ namespace GitVersion | |||
|
|
|||
| class Program | |||
| { | |||
| private const string MsBuild = @"c:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe"; | |||
There was a problem hiding this comment.
is this really safe to assume?
There was a problem hiding this comment.
Works for .net 4.0 and .net 4.5 pretty well. We can go into the registry and get the path too
But if our defaults don't work, you can specify the exe yourself with the /exe parameter
|
I deleted all the .orig files, not the actual .approved.txt |
|
@JakeGinnivan ahh. ok |
|
Rebased and fixed mentioned issues |
Added /exec and /proj arguments
Please merge #101 first. This fixed #110
I will rebase once it is merged (there will be conflicts). Feel free to review in the mean time.