-
Notifications
You must be signed in to change notification settings - Fork 651
Publish as .NET Core Global Tool #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish as .NET Core Global Tool #1528
Conversation
@dazinator thanks for the feedback, I made the changes, if you consider them ok I'll squash the commits and push them as one commit before merging |
LGTM! |
ok then, squashing the changes |
056efd5
to
0fdac1b
Compare
It's ready for the merge. Looking forward to see the global tool published. |
Merging, thanks @arturcic |
@arturcic might also be worth adding this here: https://github.com/natemcmaster/dotnet-tools/blob/master/README.md |
Yeah, that would be a great addition. Thanks |
Here it is natemcmaster/dotnet-tools#84 |
@dazinator It was merged |
I can't seem to be able to run it on my end.
I get the following error:
I should mention that this is the first time I ever used |
@Crono1981 once installed globally, you should be able to simply run:
there is no need to run Run the command Hope that helps! |
Thanks @gep13, I tried Maybe something is wrong with my PATH environment variable? I'll look it up later when I'm back to my office. Anyway, now at least I'm sure that the correct way to run the tool is |
Yep, bad PATH value. Sorry I even bothered you with this. 😞🤦♂️ |
@Crono1981 no need to apologise. Glad you got it working! |
Implements #1464
I decided to implement it as a separate PR not as part of #1422 as that PR is blocked, and we can have a global tool without upgrading to .net core 2.1.
I have used the
GitVersion.Tool
as the package ID, even thought there is a GitVersion.Tools - this one has one version and a few downloads and I don't think it will be too confusing.@gep13 , @dazinator what do you think?