Skip to content

Publish as .NET Core Global Tool #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2018

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Nov 9, 2018

Implements #1464

I decided to implement it as a separate PR not as part of #1422 as that PR is blocked, and we can have a global tool without upgrading to .net core 2.1.

I have used the GitVersion.Tool as the package ID, even thought there is a GitVersion.Tools - this one has one version and a few downloads and I don't think it will be too confusing.

@gep13 , @dazinator what do you think?

@arturcic arturcic requested a review from dazinator November 9, 2018 17:02
@arturcic
Copy link
Member Author

@dazinator thanks for the feedback, I made the changes, if you consider them ok I'll squash the commits and push them as one commit before merging

@dazinator
Copy link
Member

LGTM!

@arturcic
Copy link
Member Author

ok then, squashing the changes

@arturcic arturcic force-pushed the feature/GitVersion-Global-Tool branch from 056efd5 to 0fdac1b Compare November 11, 2018 17:32
@arturcic
Copy link
Member Author

It's ready for the merge. Looking forward to see the global tool published.

@dazinator
Copy link
Member

Merging, thanks @arturcic

@dazinator dazinator merged commit ce19760 into GitTools:master Nov 11, 2018
@arturcic arturcic deleted the feature/GitVersion-Global-Tool branch November 11, 2018 18:26
@dazinator
Copy link
Member

@arturcic might also be worth adding this here: https://github.com/natemcmaster/dotnet-tools/blob/master/README.md

@arturcic
Copy link
Member Author

Yeah, that would be a great addition. Thanks

@arturcic
Copy link
Member Author

Here it is natemcmaster/dotnet-tools#84

@arturcic
Copy link
Member Author

@dazinator It was merged

@Crono1981
Copy link

I can't seem to be able to run it on my end.

dotnet tool install GitVersion.Tool -g --version 5.0.0-beta3-4
dotnet gitversion

I get the following error:

No executable found matching command "dotnet-gitversion"

I should mention that this is the first time I ever used dotnet tool so I might be missing something obvious. Any clue?

@gep13
Copy link
Member

gep13 commented Jun 20, 2019

@Crono1981 once installed globally, you should be able to simply run:

dotnet-gitversion

there is no need to run dotnet first.

Run the command dotnet tool list -g to see all the tools that you have installed, and the commands that can be ran to execute them.

Hope that helps!

@Crono1981
Copy link

Thanks @gep13, I tried dotnet-gitversion too but then I get a message saying that it doesn't exist. Even though I do see it when I run dotnet tool list -g.

Maybe something is wrong with my PATH environment variable? I'll look it up later when I'm back to my office.

Anyway, now at least I'm sure that the correct way to run the tool is dotnet-gitversion. Thanks!

@Crono1981
Copy link

Yep, bad PATH value. Sorry I even bothered you with this. 😞🤦‍♂️

@gep13
Copy link
Member

gep13 commented Jun 20, 2019

@Crono1981 no need to apologise. Glad you got it working!

@asbjornu asbjornu mentioned this pull request Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants