nuget update #1534
Merged
nuget update #1534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturcic
force-pushed
the
feature/nuget-update
branch
from
0840357 to
d9dded8
Compare
|
@dazinator could you please have a look? |
|
@dazinator, the required changes included |
|
I'll squash as one commit and then you can merge it |
arturcic
force-pushed
the
feature/nuget-update
branch
from
9a621b2 to
8e23b5b
Compare
|
My only concern is the update to msbuild dependencies. I have found them unusually fragile in the past. However if all tests pass then thats the only solid metric we have.I still think its brave to update them ;-) |
|
Thanks, just trying to move the project forward and preparing the ground for the PR #1422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the nuget packages as part of csproj cleanup. Have updated to the latest possible, except some that have latest targeting netstandard 2.0 (those probably will be updated as part of the PR for netstandard2)