Skip to content

Update breaking changes #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2020
Merged

Update breaking changes #2351

merged 4 commits into from
Jul 9, 2020

Conversation

asbjornu
Copy link
Member

@asbjornu asbjornu commented Jul 9, 2020 •
edited
Loading

Updates BREAKING_CHANGES.md with information on what we broke in version 5.

Related Issue

Resolves #2230.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@asbjornu asbjornu requested a review from arturcic July 9, 2020 08:01
@asbjornu asbjornu force-pushed the feature/update-breaking-changes branch from 9a2ccae to 1513702 Compare July 9, 2020 08:02
@arturcic
Copy link
Member

arturcic commented Jul 9, 2020

@asbjornu you can merge it

@asbjornu asbjornu merged commit 088892f into GitTools:master Jul 9, 2020
@asbjornu asbjornu deleted the feature/update-breaking-changes branch July 9, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturcic arturcic arturcic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The BREAKING_CHANGES.md doesn't seem to be getting updated
2 participants
@asbjornu @arturcic