Skip to content

Allow building and running on Linux #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2015
Merged

Allow building and running on Linux #671

merged 5 commits into from
Oct 9, 2015

Conversation

ermshiperete
Copy link
Contributor

No description provided.

Copy existing .mdb or .pdb files. This fixes a build failure on Mono.
The subfolder site/ gets generated when building/running the
documentation.
@ermshiperete ermshiperete changed the title Fix building on Linux Allow building on Linux Oct 6, 2015
@ermshiperete ermshiperete changed the title Allow building on Linux Allow building and running on Linux Oct 7, 2015
There is no ilmerge.exe on Linux, so we use ILRepack.exe instead which
also works on Windows.
This allows to run the executable from the NuGet package on Linux (if we
manually rename/copy the LibGit2Sharp.dll.config file to
GitVersion.exe.config. We can't do that automatically because the config
file prevents GitVersion.exe from working properly on Windows).
On Linux absolute paths start with '/'.
@@ -52,7 +54,7 @@ public static Arguments ParseArguments(List<string> commandLineArguments)

List<string> namedArguments;
var arguments = new Arguments();
if (firstArgument.StartsWith("-") || firstArgument.StartsWith("/"))
if (firstArgument.StartsWith("-") || (firstArgument.StartsWith("/") && Path.DirectorySeparatorChar != '/'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we are probably going to redo the command line args in 4.0.0, which should help cross plat out as we will probably drop / arguments

@JakeGinnivan
Copy link
Contributor

Thanks! Just to set expectations, it will likely be another month or so before a 4.0.0 beta is out. I want to get the command line stuff done before I release the beta and I have quite a few speaking engagements coming up.

JakeGinnivan added a commit that referenced this pull request Oct 9, 2015
Allow building and running on Linux
@JakeGinnivan JakeGinnivan merged commit 8b8564c into GitTools:release/4.0.0 Oct 9, 2015
@ermshiperete ermshiperete deleted the Mono branch October 9, 2015 03:46
@ermshiperete
Copy link
Contributor Author

@JakeGinnivan Any idea when a 4.0.0 will be released? IIRC one problem was the need for an updated LibGit2Sharp version which has been released a few weeks now. Would be great if we could get an official 4.0.0 soon... Thanks!

@asbjornu
Copy link
Member

asbjornu commented Apr 6, 2016

@ermshiperete I've begun tackling that problem in #816, which should be possible to merge into master and release as a v3.x. If I've understood @JakeGinnivan correctly, the plan is to merge the v4.0 branch in its current state into master and let the main point of v4.0 be about breaking changes on the command line.

#816 still needs a bit of work, so I'd highly appreciate any input you might have on that, @ermshiperete, so we can have it merged into master as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants