-
Notifications
You must be signed in to change notification settings - Fork 652
Allow building and running on Linux #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copy existing .mdb or .pdb files. This fixes a build failure on Mono.
The subfolder site/ gets generated when building/running the documentation.
There is no ilmerge.exe on Linux, so we use ILRepack.exe instead which also works on Windows.
This allows to run the executable from the NuGet package on Linux (if we manually rename/copy the LibGit2Sharp.dll.config file to GitVersion.exe.config. We can't do that automatically because the config file prevents GitVersion.exe from working properly on Windows).
On Linux absolute paths start with '/'.
@@ -52,7 +54,7 @@ public static Arguments ParseArguments(List<string> commandLineArguments) | |||
|
|||
List<string> namedArguments; | |||
var arguments = new Arguments(); | |||
if (firstArgument.StartsWith("-") || firstArgument.StartsWith("/")) | |||
if (firstArgument.StartsWith("-") || (firstArgument.StartsWith("/") && Path.DirectorySeparatorChar != '/')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI we are probably going to redo the command line args in 4.0.0, which should help cross plat out as we will probably drop /
arguments
Thanks! Just to set expectations, it will likely be another month or so before a 4.0.0 beta is out. I want to get the command line stuff done before I release the beta and I have quite a few speaking engagements coming up. |
Allow building and running on Linux
@JakeGinnivan Any idea when a 4.0.0 will be released? IIRC one problem was the need for an updated LibGit2Sharp version which has been released a few weeks now. Would be great if we could get an official 4.0.0 soon... Thanks! |
@ermshiperete I've begun tackling that problem in #816, which should be possible to merge into #816 still needs a bit of work, so I'd highly appreciate any input you might have on that, @ermshiperete, so we can have it merged into |
No description provided.