-
Notifications
You must be signed in to change notification settings - Fork 652
Working Travis build #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Working Travis build #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use lowercase `b` in `build` for improved compatibility with case-sensitive file systems.
Base the current directory of the documentation tests on the location of the test assembly instead of `Environment.CurrentDirectory`.
Add 'NoMono' category to AssemblyInfoBuilder tests since source information is not available to `ShouldMatchApproved()` on Mono.
Deleted test that effectively only tested the ProcessHelper; not GitVersion.exe, as it appeared to.
Deleted ProcessHelper and replaced usage with the one from GitTools.Core.
… reintroduce the NuGet dependencies to System.*
Hm, why isn't AppVeyor building this, by the way? |
@asbjornu good question. @JakeGinnivan any ideas? |
Merged
Closing in favor of #856, which is being built by AppVeyor right this moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the Mono support started in #816 and contains fixes all over the place to achieve a working build on Travis. Most tests are executed and succeed, but some tests using the
ShouldMatchApproved()
extension method from Shouldly had to be ignored, since they fail due to missing source information.If Shouldly gains Mono
.mdb
symbol support, these tests can be un-ignored and the Travis (Linux) build of GitVersion should be on par with Windows and we should be in a great place to ensure Unix, Linux and Mono compatibility going forward.After merging this, a Travis build badge like this can be added to the README: