Always let Dependabot propose Cargo.lock updates
#1967
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the `dependabot.yml` configuration since GitoxideLabs#1948, where we intend Dependabot to include the effect of `cargo update`, but this does not happen because `dependency-type: all` was not explicitly allowed. This does not make an analogous change to the Dependabot configuration for GitHub Actions, because `all` and `direct` currently have the same effect for them (and it is not obvious how it would work if that ever changes, or which we would prefer). For details on why this is needed for Dependabot to update most locked dependencies in `Cargo.lock` aside from the case where the update is done as part of updating a `Cargo.toml` dependency, see: - https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/controlling-dependencies-updated#allowing-specific-dependencies-to-be-updated - https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#dependency-type-allow
|
The failure is due to #1816 and not related to any changes in this PR. I will rerun the workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
dependabot.ymlconfiguration since #1948, where we intend Dependabot to include the effect ofcargo update, but this does not happen becausedependency-type: allwas not explicitly allowed.This does not make an analogous change to the Dependabot configuration for GitHub Actions, because
allanddirectcurrently have the same effect for them (and it is not obvious how it would work if that ever changes, or which we would prefer).For details on why this is needed for Dependabot to update most locked dependencies in
Cargo.lockaside from the case where the update is done as part of updating aCargo.tomldependency, see:This does not change the cadence, which is still set to monthly. Dependabot will perform a check after this is merged, because any change to
dependabot.ymltriggers new Dependabot version update checks for all configured ecosystems. It will open a PR because there will be updates, most but not all of which will be changes toCargo.lockupdating transitive dependencies that were not covered before due to the configuration shortcoming that this is fixing.The fork-internal Dependabot test PR I used to verify these changes, formed by pushing this change to main in my fork and subsequently rewinding, was EliahKagan#22. This roughly reflects what the first Dependabot PR after this configuration change is merged will look like.
I will make a corresponding change to
dependabot.ymlincargo-smart-release, where GitoxideLabs/cargo-smart-release#52 had the same bug as #1948. (Edit: This change is GitoxideLabs/cargo-smart-release#58.)No such change in
prodashis needed. This is because Dependabot version updates are only used for GitHub Actions, not for Rust/cargodependencies, and also because we are not currently committingCargo.lockinprodash.The problem this is fixing does not affect the behavior of Dependabot security updates, which are already attempted for all types of dependencies.