Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
zizmor found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…doring This is the baseline version, with a DoS issue fixed due to out-of-bound computation. Drop large JSON performance-test fixtures and the perf-only test that used them.
…doring It contains a DoS fix for a runaway computation. Drop large JSON performance-test fixtures and the perf-only test that used them.
Sebastian Thiel (Byron)
force-pushed
the
vendor-imara-diff
branch
2 times, most recently
from
10f4aa6 to
96ee65b
Compare
Sebastian Thiel (Byron)
force-pushed
the
vendor-imara-diff
branch
from
96ee65b to
beb7509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take
imara-diffin and unify both versions of it, one that has sliders, the other one that doesn't.See what LLMs can do as well if they see both versions at the same time easily.
Tasks