Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updating genai tests to run on same gcp project as ai platform samples #3596

Merged
merged 8 commits into from
Feb 21, 2024
Merged

fix: updating genai tests to run on same gcp project as ai platform samples #3596

merged 8 commits into from
Feb 21, 2024

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Dec 20, 2023 •
edited
Loading

Description

Replaces which GCP projects tests will get run for genai samples.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@pattishin pattishin requested review from a team as code owners December 20, 2023 04:52
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: genai labels Dec 20, 2023
@pattishin pattishin changed the title fix: updating genai tests to run on same gcp project as ai platform samples fix(wip): updating genai tests to run on same gcp project as ai platform samples 🚧 Dec 20, 2023
@pattishin pattishin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 21, 2023
@pattishin pattishin changed the title fix(wip): updating genai tests to run on same gcp project as ai platform samples 🚧 fix: updating genai tests to run on same gcp project as ai platform samples Feb 15, 2024
@pattishin pattishin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 15, 2024
@pattishin pattishin merged commit 4892dff into main Feb 21, 2024
31 of 32 checks passed
@pattishin pattishin deleted the fix/update-samples-gha-workflows branch February 21, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gericdong gericdong gericdong approved these changes

@LukeSchlangen LukeSchlangen Awaiting requested review from LukeSchlangen

Assignees
No one assigned
Labels
actions:force-run api: genai samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pattishin @gericdong