Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add model to each function #3598

Merged
merged 2 commits into from
Dec 22, 2023
Merged

add model to each function #3598

merged 2 commits into from
Dec 22, 2023

Conversation

LukeSchlangen
Copy link
Member

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@LukeSchlangen LukeSchlangen requested review from a team as code owners December 21, 2023 20:16
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Dec 21, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 9 region tags.
You are about to delete 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: genai labels Dec 21, 2023
gericdong
gericdong approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@gericdong gericdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gericdong gericdong merged commit 62253bb into main Dec 22, 2023
10 of 12 checks passed
@gericdong gericdong deleted the feature/add-model-name branch December 22, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gericdong gericdong gericdong approved these changes

Assignees
No one assigned
Labels
api: genai samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeSchlangen @gericdong