Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snake case instead of pascalCase as it conflicts with types #3612

Closed

Conversation

5war00p
Copy link

@5war00p 5war00p commented Jan 18, 2024

Description

Fixes #3611

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@5war00p 5war00p requested review from a team as code owners January 18, 2024 06:49
Copy link

google-cla bot commented Jan 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: genai labels Jan 18, 2024
@5war00p 5war00p changed the title fix: snake case instead of pascalCase as it conflicts types fix: snake case instead of pascalCase as it conflicts with types Jan 18, 2024
@pattishin
Copy link
Contributor

Please see #3611 (comment).

@pattishin
Copy link
Contributor

Closing out (comment)

@pattishin pattishin closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: genai samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: multiparts doesn't match to defined types (Part)
2 participants