Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-3503): resolve run/helloworld NAME override error 🚧 #3636

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions run/helloworld/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,7 @@ app.listen(port, () => {
// [END run_helloworld_service]
// [END cloudrun_helloworld_service]

// Hello

// Exports for testing purposes.
export default app;
4 changes: 4 additions & 0 deletions run/helloworld/test/system.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@

it('Service uses the NAME override', async () => {
const response = await get('/', BASE_URL);

Check failure on line 96 in run/helloworld/test/system.test.js

View workflow job for this annotation

GitHub Actions / lint

Delete `····`

Check failure on line 96 in run/helloworld/test/system.test.js

View workflow job for this annotation

GitHub Actions / lint

Trailing spaces not allowed
console.log('-------');
console.log(BASE_URL);

Check failure on line 99 in run/helloworld/test/system.test.js

View workflow job for this annotation

GitHub Actions / lint

Delete `····`

Check failure on line 99 in run/helloworld/test/system.test.js

View workflow job for this annotation

GitHub Actions / lint

Trailing spaces not allowed
assert.strictEqual(
response.statusCode,
200,
Expand Down
Loading