Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-3631): updating samples to all use node v20 (part 3) #3640

Closed
wants to merge 1 commit into from
Closed

fix(issue-3631): updating samples to all use node v20 (part 3) #3640

wants to merge 1 commit into from

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Mar 8, 2024 •
edited
Loading

Description

Issue #3631 Refactoring out from original PR to manually updating node to latest stable v20
Part 2 to #3617 update from @iennae.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. api: appengine Issues related to the App Engine Admin API API. api: auth api: automl Issues related to the AutoML API. api: batch Issues related to the Batch API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudbuild Issues related to the Cloud Build API. api: cloudsql Issues related to the Cloud SQL for MySQL API. api: composer Issues related to the Cloud Composer API. api: compute Issues related to the Compute Engine API. api: contactcenterinsights Issues related to the Contact Center AI Insights API. api: container Issues related to the Kubernetes Engine API API. api: containeranalysis Issues related to the Container Analysis API. api: datacatalog Issues related to the Data Catalog API. api: datalabeling Issues related to the AI Platform Data Labeling Service API. api: language Issues related to the Cloud Natural Language API API. api: tasks Issues related to the Tasks API API. asset: pattern DEE Asset tagging - Pattern. labels Mar 8, 2024
@pattishin pattishin changed the title fix(issue-3631): updating samples to all use node v20 fix(issue-3631): updating samples to all use node v20 (part 3) Mar 8, 2024
@pattishin pattishin mentioned this pull request Mar 8, 2024
Closed
1 task
@pattishin pattishin closed this Apr 24, 2024
@pattishin pattishin deleted the refactor/to-latest-node-20 branch April 24, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. api: appengine Issues related to the App Engine Admin API API. api: auth api: automl Issues related to the AutoML API. api: batch Issues related to the Batch API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudbuild Issues related to the Cloud Build API. api: cloudsql Issues related to the Cloud SQL for MySQL API. api: composer Issues related to the Cloud Composer API. api: compute Issues related to the Compute Engine API. api: contactcenterinsights Issues related to the Contact Center AI Insights API. api: container Issues related to the Kubernetes Engine API API. api: containeranalysis Issues related to the Container Analysis API. api: datacatalog Issues related to the Data Catalog API. api: datalabeling Issues related to the AI Platform Data Labeling Service API. api: language Issues related to the Cloud Natural Language API API. api: tasks Issues related to the Tasks API API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pattishin