Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused error concepts function snippets #3669

Merged
merged 5 commits into from
May 2, 2024
Merged

fix: remove unused error concepts function snippets #3669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8cda404
fix: remove unused error concepts function snippets
iennae May 2, 2024
0e44c0f
Merge branch 'main' into sigje-remove-unused-functions-region-tags
iennae May 2, 2024
0c0eb9b
fix: cleaning up lint
iennae May 2, 2024
9c9e197
fix: moving region tag to not include the ending }
iennae May 2, 2024
169a271
fix: more linting issues
iennae May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions functions/helloworld/helloError/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

'use strict';

const functions = require('@google-cloud/functions-framework');

/* eslint-disable no-unused-vars */

/**
Expand All @@ -32,41 +30,3 @@ exports.helloError = (event, context, callback) => {
throw new Error('I failed you'); // Will cause a cold start if not caught
// [END functions_helloworld_error]
};

/**
* Background Cloud Function that throws a value.
*
* @param {object} event The Cloud Functions event.
* @param {object} context The event metadata.
* @param {function} callback The callback function.
*/
exports.helloError2 = (event, context, callback) => {
// [START functions_helloworld_error_2]
// These WILL be reported to Error Reporting
console.error(new Error('I failed you')); // Logging an Error object
console.error('I failed you'); // Logging something other than an Error object
throw 1; // Throwing something other than an Error object
// [END functions_helloworld_error_2]
};

/**
* Background Cloud Function that returns an error.
*
* @param {object} event The Cloud Functions event.
* @param {object} context The event metadata.
* @param {function} callback The callback function.
*/
exports.helloError3 = (event, context, callback) => {
// [START functions_helloworld_error_3]
// This will NOT be reported to Error Reporting
callback('I failed you');
// [END functions_helloworld_error_3]
};

// HTTP Cloud Function that returns an error.
functions.http('helloError4', (req, res) => {
// [START functions_helloworld_error_4]
// This will NOT be reported to Error Reporting
res.status(500).send('I failed you');
// [END functions_helloworld_error_4]
});
21 changes: 0 additions & 21 deletions functions/helloworld/helloError/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
// limitations under the License.

const assert = require('assert');
const sinon = require('sinon');

const program = require('..');

describe('index.test.js', () => {
Expand All @@ -25,23 +23,4 @@ describe('index.test.js', () => {
});
});
});

describe('functions_helloworld_error_2', () => {
describe('Error handling (unit tests)', () => {
it('helloError2: should throw a value', () => {
assert.throws(program.helloError2, '1');
});
});
});

describe('functions_helloworld_error_3', () => {
describe('Error handling (unit tests)', () => {
it('helloError3: callback should return an errback value', () => {
const cb = sinon.stub();
program.helloError3(null, null, cb);
assert.ok(cb.calledOnce);
assert.ok(cb.calledWith('I failed you'));
});
});
});
});
Loading