Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create_batch_custom_network #3793

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Aug 13, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj added samples Issues that are directly related to samples. api: batch Issues related to the Batch API. labels Aug 13, 2024
@gryczj gryczj self-assigned this Aug 13, 2024
@gryczj gryczj requested review from a team as code owners August 13, 2024 14:28
Copy link

snippet-bot bot commented Aug 13, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 13, 2024
@gryczj gryczj force-pushed the batch-create-custom-network branch from cf0cb8a to 7073c0c Compare August 13, 2024 14:29
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 13, 2024
subfuzion

This comment was marked as resolved.

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 14, 2024
@gryczj gryczj force-pushed the batch-create-custom-network branch from 7073c0c to 1a98270 Compare August 14, 2024 08:46
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 14, 2024
@gryczj gryczj requested a review from subfuzion August 14, 2024 08:53
@gryczj gryczj force-pushed the batch-create-custom-network branch from 1a98270 to 05094fc Compare August 16, 2024 13:52
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 19, 2024
@gryczj gryczj force-pushed the batch-create-custom-network branch from 05094fc to 0773cdd Compare August 19, 2024 17:02
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 19, 2024
@gryczj gryczj force-pushed the batch-create-custom-network branch from 0773cdd to f39b003 Compare August 20, 2024 07:36
Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gryczj Looking good, just a few more nits. Thanks.

batch/test/create_batch_custom_network.test.js Outdated Show resolved Hide resolved
batch/test/create_batch_custom_network.test.js Outdated Show resolved Hide resolved
@subfuzion subfuzion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2024
@gryczj gryczj force-pushed the batch-create-custom-network branch from 665fbc6 to a77bf2a Compare August 21, 2024 12:39
@gryczj gryczj force-pushed the batch-create-custom-network branch 2 times, most recently from 8f0ea59 to 6c93e77 Compare August 22, 2024 08:43
subfuzion

This comment was marked as resolved.

@gryczj gryczj force-pushed the batch-create-custom-network branch from 105166f to 097ef1e Compare August 23, 2024 06:02
@gryczj gryczj requested a review from subfuzion August 23, 2024 06:09
@subfuzion subfuzion merged commit 933522c into main Aug 23, 2024
32 checks passed
@subfuzion subfuzion deleted the batch-create-custom-network branch August 23, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: batch Issues related to the Batch API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants