-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (data_catalog) migrate region tag #3946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:
This pull request, submitted by @hivanalejandro, aims to fix a bug by migrating a region tag in the nodejs-docs-samples
repository. Specifically, it updates the datacatalog/cloud-client/createEntryGroup.js
file.
Here's a breakdown of the changes:
- Intent: Migrate the region tag from
datacatalog_create_entry_group_tag
todata_catalog_create_entry_group_tag
. - Changes:
- The file
datacatalog/cloud-client/createEntryGroup.js
has been modified. - Lines 28-29 were modified to include both
data_catalog_create_entry_group_tag
anddatacatalog_create_entry_group_tag
. The original tag was preserved. - Line 63 was modified to include both
data_catalog_create_entry_group_tag
anddatacatalog_create_entry_group_tag
. The original tag was preserved.
- The file
- Associated Issue: This PR fixes issue b/389693076.
The author has indicated that all tests and linting checks have passed. They've also confirmed adherence to the project's contribution guidelines.
A little haiku to brighten your day:
Tags shift, code refined,
Bugs flee, a smoother system,
Joy in clean commits.
Thanks,
Gemini
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The region tag was migrated successfully.
@@ -25,11 +25,12 @@ | |||
projectId = process.env.GOOGLE_CLOUD_PROJECT, | |||
entryGroupId | |||
) => { | |||
// [START data_catalog_create_entry_group_tag] | |||
// [START datacatalog_create_entry_group_tag] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Migrate region "datacatalog_create_entry_group_tag" to "data_catalog_create_entry_group_tag"
Fixes b/389693076
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.