Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (data_catalog) migrate region tag #3947

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Jan 14, 2025

Description

Migrate region "datacatalog_create_fileset_quickstart_tag" to "data_catalog_create_fileset_quickstart_tag"

Fixes b/389763067

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners January 14, 2025 03:42
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 14, 2025
Copy link

snippet-bot bot commented Jan 14, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: datacatalog Issues related to the Data Catalog API. label Jan 14, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, submitted by @hivanalejandro, aims to migrate the region tag in the nodejs-docs-samples repository's datacatalog quickstart sample. Specifically, it addresses issue b/389763067.

The changes involve updating the createFilesetEntry.js file:

  • The old region tag datacatalog_create_fileset_quickstart_tag is replaced with the new tag data_catalog_create_fileset_quickstart_tag.
  • This change is reflected both at the beginning and end of the main function (lines 29-30 and 128-129 respectively).

The author has indicated that all tests and linting checks have passed. The checklist in the PR description confirms this.

I'll provide a more detailed review shortly, but this summary should give everyone a good overview of the changes.


A little poem to brighten your day:

Tags shift, a code's new hue,
A region's name, refreshed and true,
Bugs flee, the fix is done.

Best,
Gemini/code-review-assist

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The region tag was duplicated in the before patch, this has been corrected. Also, the checklist should be completed before requesting a merge.

@@ -26,6 +26,7 @@ const main = async (
entryGroupId,
entryId
) => {
// [START data_catalog_create_fileset_quickstart_tag]
// [START datacatalog_create_fileset_quickstart_tag]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Duplicated region tag, remove this line.

Comment on lines 127 to 128
};
// [END datacatalog_create_fileset_quickstart_tag]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The checklist should be updated before requesting this PR to be merged.

@glasnt glasnt merged commit abdb358 into main Jan 21, 2025
15 checks passed
@glasnt glasnt deleted the hivanalejandro-migrate-region-step1-389763067 branch January 21, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datacatalog Issues related to the Data Catalog API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants