Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (data_catalog) migrate region tag in deleteFilesetEntry.js #3949

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Jan 14, 2025

Description

Migrate region "datacatalog_delete_fileset_quickstart_tag" to "data_catalog_delete_fileset_quickstart_tag"

Fixes b/389895440

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners January 14, 2025 14:01
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed:

This pull request, submitted by @hivanalejandro, aims to fix a bug (b/389895440) by migrating a region tag in the deleteFilesetEntry.js file within the datacatalog/quickstart directory.

Specifically, the changes involve updating the region tag from datacatalog_delete_fileset_quickstart_tag to data_catalog_delete_fileset_quickstart_tag.

Here's a breakdown of the changes:

  • File: datacatalog/quickstart/deleteFilesetEntry.js
    • Changes: The region tag was updated on lines 29 and 74. The data_catalog_delete_fileset_quickstart_tag was added on line 29, and the same tag was added on line 76.

The author has indicated that all tests and linting checks have passed. The pull request is ready for merging once approved.


A little haiku to lighten the mood:

Tags shift, code flows free,
Bugs vanish, a cleaner scene,
Joy in the merge.

Thanks,
Gemini

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 14, 2025
Copy link

snippet-bot bot commented Jan 14, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: datacatalog Issues related to the Data Catalog API. label Jan 14, 2025
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change correctly migrates the region tag as requested. However, the original region tag should be removed entirely instead of being duplicated.

Comment on lines 29 to 30
// [START data_catalog_delete_fileset_quickstart_tag]
// [START datacatalog_delete_fileset_quickstart_tag]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The old region tag datacatalog_delete_fileset_quickstart_tag should be removed instead of being duplicated. The correct region tag is data_catalog_delete_fileset_quickstart_tag.

Suggested change
// [START data_catalog_delete_fileset_quickstart_tag]
// [START datacatalog_delete_fileset_quickstart_tag]
// [START data_catalog_delete_fileset_quickstart_tag]

Comment on lines 75 to 76
// [END datacatalog_delete_fileset_quickstart_tag]
// [END data_catalog_delete_fileset_quickstart_tag]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Remove the old region tag here as well.

Suggested change
// [END datacatalog_delete_fileset_quickstart_tag]
// [END data_catalog_delete_fileset_quickstart_tag]
// [END data_catalog_delete_fileset_quickstart_tag]

@NimJay NimJay merged commit fb12269 into main Jan 16, 2025
15 checks passed
@NimJay NimJay deleted the hivanalejandro-migrate-region-step1-389895440 branch January 16, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datacatalog Issues related to the Data Catalog API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants