-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (appengine) update region tag in appengine/websockets/app.js & appengine/websockets/views/index.pug #3956
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e0a189b
fix: (appengine) update region tag in appengine/websockets/app.js
hivanalejandro 429c94e
fix: (appengine) update region tag in appengine/websockets/views/inde…
hivanalejandro 5828320
Merge branch 'main' into hivanalejandro-migrate-region-step1-391399101
hivanalejandro c422a62
fix: (websockets) correct test name fromappengine_websockets_app to g…
hivanalejandro a36dc97
added the appengine_websockets_app test
hivanalejandro 526037e
Merge branch 'main' into hivanalejandro-migrate-region-step1-391399101
iennae f7fee24
Merge branch 'main' into hivanalejandro-migrate-region-step1-391399101
iennae 65042a5
Merge branch 'main' into hivanalejandro-migrate-region-step1-391399101
iennae ec6f4e1
Merge branch 'main' into hivanalejandro-migrate-region-step1-391399101
iennae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
|
||
'use strict'; | ||
|
||
// [START gae_websockets_app] | ||
// [START appengine_websockets_app] | ||
const app = require('express')(); | ||
app.set('view engine', 'pug'); | ||
|
@@ -39,5 +40,6 @@ if (module === require.main) { | |
}); | ||
} | ||
// [END appengine_websockets_app] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
// [END gae_websockets_app] | ||
|
||
module.exports = server; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the Samples Style Guide, it's best to remove the old region tags when they are no longer used. Since
gae_websockets_app
replacesappengine_websockets_app
, the latter can be removed.