Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appengine): remove older region tag #3965

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Jan 30, 2025

Description

Fixes b/392915923

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners January 30, 2025 17:21
@product-auto-label product-auto-label bot added api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples. asset: pattern DEE Asset tagging - Pattern. labels Jan 30, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, chore(appengine): remove older region tag, aims to remove outdated region tags from the appengine/building-an-app/update/server.js file. The intent is to clean up the code and improve maintainability by removing redundant comments related to enabling URL-encoded body parsing. Specifically, the change removes two comment blocks, // [START enable_parser] and // [END enable_parser], which are no longer necessary.

Here's a breakdown of the changes:

  • File Changed: appengine/building-an-app/update/server.js
  • Lines Changed: Lines 25-30 were modified. The before and after snippets show the removal of the redundant comment blocks.

Before:

25:// [START enable_parser]
26:// [START gae_enable_parser]
27:// This middleware is available in Express v4.16.0 onwards
28:app.use(express.urlencoded({extended: true}));
29:// [END gae_enable_parser]
30:// [END enable_parser]

After:

25:// [START gae_enable_parser]
26:// This middleware is available in Express v4.16.0 onwards
27:app.use(express.urlencoded({extended: true}));
28:// [END gae_enable_parser]

The pull request also references a bug fix (b/392915923), suggesting this cleanup is likely part of a larger effort to address that issue.

I'll have a more detailed review shortly. Thanks!


A little haiku to brighten your day:

Code clean and bright,
Old tags vanish from the sight,
Fresh code takes its place.

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes an older region tag enable_parser which is now replaced by gae_enable_parser. The change is small and straightforward. The updated code adheres to the project's style guidelines.

Copy link

snippet-bot bot commented Jan 30, 2025

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@glasnt glasnt merged commit e1a235d into main Feb 6, 2025
15 checks passed
@glasnt glasnt deleted the hivanalejandro-migrate-region-step4-392915923 branch February 6, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants