fix: add repository guard to workflow_run test jobs to prevent fork code execution#4304
Open
adilburaksen wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custard-run.yamlandcustard-run-dev.yamlboth trigger onworkflow_runwhen the Custard CI workflow starts. Thetestjob checks out and executes the fork's code with live GCP credentials (kokoro-system-test@long-door-651) without verifying that the triggering workflow came from the same repository.Attack: Any GitHub user with a previously merged PR (bypassing first-time-contributor approval) can open a fork PR and have their
Makefileexecute on Google's CI runner with live GCP WIF credentials.Fix
Adds an
if:guard to thetestjob in both workflow files:This ensures that for
workflow_runtriggers, only PRs from the same repository (not forks) proceed to the GCP-authenticated test step.Files Changed
.github/workflows/custard-run.yaml— added repository guard totestjob.github/workflows/custard-run-dev.yaml— same fix appliedReferences
google/adk-samples#1728(same pattern, fixed)