-
Notifications
You must be signed in to change notification settings - Fork 1.5k
gradle release v3.4.7 #4424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
gradle release v3.4.7 #4424
Conversation
Summary of ChangesHello @cloud-java-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's development version in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to update the version for the next development cycle following the v3.4.7 release. However, it introduces a version inconsistency between jib-gradle-plugin and jib-maven-plugin. While the gradle plugin's version is being updated, the maven plugin's version is left unchanged. For project consistency, these versions should be synchronized. I have added a comment detailing the issue and the required fix.
| @@ -1 +1 @@ | |||
| version = 3.4.6-SNAPSHOT | |||
| version = 3.4.8-SNAPSHOT | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version bump to 3.4.8-SNAPSHOT appears correct for the next development cycle after the v3.4.7 release. However, there are a couple of versioning inconsistencies:
- The previous version was
3.4.6-SNAPSHOT, while thejib-maven-pluginis at3.4.7-SNAPSHOT. This indicates the versions were already out of sync. - This change updates only the
jib-gradle-plugin, leavingjib-maven-pluginat3.4.7-SNAPSHOT.
To maintain consistency across the project, both plugins should have the same version. Please also update the version in jib-maven-plugin/gradle.properties to 3.4.8-SNAPSHOT within this pull request.
To be merged after the release is complete.