-
Couldn't load subscription status.
- Fork 1.5k
maven release v3.4.7 #4426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
maven release v3.4.7 #4426
Conversation
Summary of ChangesHello @cloud-java-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine version update, advancing the project's snapshot version from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the version of jib-maven-plugin to 3.4.8-SNAPSHOT. While this seems to be a standard post-release version bump following the v3.4.7 release, the way the version is changed is unconventional. It's being updated from one snapshot version to another, which could cause confusion or indicate a gap in the release process. My review includes a comment highlighting this potential versioning issue.
| @@ -1 +1 @@ | |||
| version = 3.4.7-SNAPSHOT | |||
| version = 3.4.8-SNAPSHOT | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version bump from 3.4.7-SNAPSHOT to 3.4.8-SNAPSHOT seems inconsistent with the pull request title "maven release v3.4.7". A typical release workflow involves moving from a snapshot to a stable version (e.g., 3.4.7-SNAPSHOT to 3.4.7) for the release, and then bumping to the next snapshot version (3.4.8-SNAPSHOT) for development. This change appears to skip the stable 3.4.7 version, which could be misleading.
To be merged after the release is complete.