This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Integration test for caching #3493
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current integration tests fall short when it comes to verifying caching. They only check whether we can rebuild from cache and that the resulting files are identical. They do not test however whether we had any cache misses. With this change we make the tests a bit more stringent, a test is deemed passed if and only if all layers are identical, which means all layers must have been loaded from cache.
This is currently violated in four scenarios in the existing integration tests:
COPYinstruction is used without--cache-copy-layersWORKDIRis implictly creating a folderADDinstruction is usedRUNinstruction results in empty layerI therefore removed them from the cache-integration tests and created ready-to-use integration tests for those scenarios to verify they are fixed.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.