Skip to content

Commit

Permalink
fix in list display for characters with name variations with diacritics
Browse files Browse the repository at this point in the history
  • Loading branch information
jochenGCD committed Feb 6, 2025
1 parent 1f82bc8 commit 691642a
Showing 1 changed file with 20 additions and 5 deletions.
25 changes: 20 additions & 5 deletions apps/gcd/views/details.py
Original file line number Diff line number Diff line change
Expand Up @@ -3917,11 +3917,26 @@ def character_name_issues(request, character_name_id, universe_id=None):
if character.active_generalisations().filter(
from_character__character_names__name=character_name.name):
filter_character = character.active_generalisations().get()\
.from_character
filter_character_name = filter_character.character_names\
.get(name=
character_name.name,
deleted=False)
.from_character
try:
filter_character_name = \
filter_character.character_names.get(
name=character_name.name,
deleted=False)
except CharacterNameDetail.MultipleObjectsReturned:
# This can happen due to diacritics, so we try to find the
# exact match.
found = False
for name in filter_character.character_names\
.filter(name=character_name.name,
deleted=False):
if name.name == character_name.name:
filter_character_name = name
found = True
break
if not found:
# more a CharacterNameDetail.DoesNotExist exception here ?
raise
else:
return render(request, 'indexer/error.html',
{'error_text':
Expand Down

0 comments on commit 691642a

Please sign in to comment.