-
Notifications
You must be signed in to change notification settings - Fork 11
refactor: use standardized swift-async-algorithms #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adopts the more common (now-a-days) swift-async-algorithms for the simple async collection needs of this package. Helps adopt the standardized ecosystem where many other packages use swift-async-algorithms.
I believe if you change this line from DataLoader/.github/workflows/build.yml Line 54 in 52b1f3d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @Austinpayne
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution! 🙂
Sweet, thanks! Pushed up a change to upgrade to v4. |
You replaced |
Yeah, it's true the semantics are different. Feel free to close if this potential performance change is unacceptable. I don't see any benchmarks in this package so I don't have a good way to qualify this change. |
I'm inclined to agree with @ZirgVoice. Batching works by slightly pausing execution to allow more I'm realizing that we ought to add a test that validates this functionality for |
Sounds good, thanks for the feedback! |
Adopts the more common (now-a-days) swift-async-algorithms for the simple async collection needs of this package. Helps adopt the standardized ecosystem where many other packages use swift-async-algorithms.