Skip to content

Conversation

NeedleInAJayStack
Copy link
Member

This switches to the centralized GraphQLSwift CI repo for better maintainability.

@NeedleInAJayStack NeedleInAJayStack self-assigned this Jun 28, 2025
@NeedleInAJayStack NeedleInAJayStack requested review from Copilot and paulofaria and removed request for Copilot June 28, 2025 17:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches the repository’s CI configuration to use the centralized GraphQLSwift CI workflows and updates several SubscribeField initializers to explicitly ignore an unused FieldType.Type parameter.

  • Swap out local GitHub Actions in .github/workflows/build.yml for calls to the shared GraphQLSwift CI repo.
  • Remove the old build.yml file and introduce .github/workflows/test.yaml that references the centralized lint and test workflows.
  • Update multiple SubscriptionField convenience initializers to mark the FieldType.Type parameter as unused.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Sources/Graphiti/Subscription/SubscribeField.swift Changed as: FieldType.Type to as _: FieldType.Type to silence unused-parameter warnings
.github/workflows/test.yaml Added workflow that uses GraphQLSwift/ci lint and test jobs
.github/workflows/build.yml Removed local build workflow in favor of centralized CI
Comments suppressed due to low confidence (1)

Sources/Graphiti/Subscription/SubscribeField.swift:453

  • The FieldType.Type parameter is now ignored (using _). If this parameter is no longer needed, consider removing it from the API to simplify the initializer signature and avoid confusion for users.
        as _: FieldType.Type,

@NeedleInAJayStack NeedleInAJayStack merged commit d6f2bb1 into GraphQLSwift:main Jul 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants