Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onboarding screen #351

Merged
merged 4 commits into from
Feb 20, 2025
Merged

fix: onboarding screen #351

merged 4 commits into from
Feb 20, 2025

Conversation

pierrelstan
Copy link
Collaborator

@pierrelstan pierrelstan commented Feb 20, 2025

Description

Make the Onboarding screen display only on the first launch.
The following changes have been implemented:

  • add custom button
  • update _layout app
  • add verify verifyAppLaunchStatus

Resolves #350


Changes Made

  • Changes in apps folder (specify the app and briefly describe the changes):

    • Web
    • Native
  • Changes in packages folder (specify the package and briefly describe the changes):

    • Core

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update (changes)

Screenshots

Before After
"screenshot before" "screenshot after"

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Comments

(Optional) Add any additional comments or notes for reviewers here.

@pierrelstan pierrelstan requested a review from a team as a code owner February 20, 2025 04:35
@pierrelstan pierrelstan merged commit df766df into main Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix on Boarding screen in Expo
1 participant