refactor!: update to flutter rust bridge v2

[mcmah309]

closes #331

[GregoryConrad]

This is a huge help! TYSM!

It'll take awhile to review all of this (especially since I didn't look in-depth at the FRB v2 changes), so please bear with me while I take a look!

Edit: wasn't as bad as the diff made it out to be--mostly just code gen file updates 😄

[GregoryConrad]

I think what you have so far is good!

If it's ok with you, can I use this PR to finish up some misc things (like iOS/macOS/CI/CD)? Then I can merge it in once I'm done with that.

[mcmah309]

Yeah that works!

[GregoryConrad]

I need to go to bed so I'll leave some notes here on where I left off:

// flutter_interface.dart
  /// Creates a [MimirInstance] from the given path for Flutter
  Future<MimirInstance> getInstanceForPath(String path) =>
      getInstance(path: path); // TODO do we need ioDirectory?

# combine-prs

          cargo build -r
          # TODO update generated files
          # TODO run code formatter
          git config --global user.name 'MimirActionsBot'
          git config --global user.email '[email protected]'
          git commit -am "chore: update generated files"
          git push

• Try macos-latest in regular build CI file

[GregoryConrad]

Switching to dynamic linking would be a one-line fix on iOS/macOS if it weren't for CocoaPods. Thanks CocoaPods! Now I get to rediscover how to get iOS/macOS builds working again.

Looked into Swift Package Manager integration into Flutter but that appears as though it'll take some time before it reaches stable. So will need to find a new solution that deals with CocoaPods in the meantime.

[mcmah309]

Yup, sounds like flutter development 😅

Btw, for this failure, I manually changed it to just String to get it to work. There was one more spot too where I had to add an int cast. Likely bugs in the current flutter rust bridge version.

edit: I see you just fixed it. Nice timing.

[GregoryConrad]

Btw, for this failure, I manually changed it to just String to get it to work. There was one more spot too where I had to add an int cast. Likely bugs in the current flutter rust bridge version.

Hm. I fixed the toString failure by excluding it from codegen (since it was never supposed to be included in codegen anyways). Some bug in FRB made it get included even though it wasn't pub.

Also haven't seen the int casting issue pop-up--maybe something else I did fixed that.

[GregoryConrad]

I think I'm going to do a temp fix here for iOS/macOS that reverts to using the discouraged ExternalLibrary.process method until Swift Package Manager support in Flutter rolls. That way I avoid having to rewrite and re-experiment with all of the iOS/macOS build stuff (which is extremely time consuming). I have the basics of dynamic libraries working with CocoaPods but it'll require quite a few hacks to get right, and since we are already using hacks with ExternalLibrary.process, might as well use the hack that enables the most code re-use.

That being said, notes to future self once SPM support comes:

• update build-apple.sh to use .dylib instead of .a
• update interface.dart in mimir to remove ExternalLibrary.process workaround