Skip to content

🧹 [code health improvement] Consolidate header construction in JulesClient #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GreyC wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🧹 [code health improvement] Consolidate header construction in JulesClient #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/cli/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,21 @@ export class JulesClient {
this.apiKey = apiKey || getApiKey();
}

private getHeaders(): Record<string, string> {
private static buildHeaders(apiKey: string): Record<string, string> {
return {
'x-goog-api-key': this.apiKey,
'x-goog-api-key': apiKey,
'Content-Type': 'application/json',
Comment on lines +14 to 15
Copy link

@gemini-code-assist gemini-code-assist bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and prevent potential typos, it's a good practice to define hardcoded strings for headers and content types as constants rather than using them as "magic strings" directly in the code.

You could define them as static readonly properties on the JulesClient class and reference them here. For example:

// At the top of the JulesClient class
private static readonly API_KEY_HEADER = 'x-goog-api-key';
private static readonly CONTENT_TYPE_HEADER = 'Content-Type';
private static readonly JSON_CONTENT_TYPE = 'application/json';

// In buildHeaders method
return {
  [JulesClient.API_KEY_HEADER]: apiKey,
  [JulesClient.CONTENT_TYPE_HEADER]: JulesClient.JSON_CONTENT_TYPE,
};

This change would make the header definitions more centralized and easier to manage.

};
}

private getHeaders(): Record<string, string> {
return JulesClient.buildHeaders(this.apiKey);
}

static async validateKey(apiKey: string): Promise<boolean> {
const response = await fetch(`${BASE_URL}/sessions`, {
method: 'GET',
headers: {
'x-goog-api-key': apiKey,
'Content-Type': 'application/json',
},
headers: JulesClient.buildHeaders(apiKey),
});

if (!response.ok) {
Expand Down
Loading