Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

31 ci benchmarking #32

Open
wants to merge 86 commits into
base: main
Choose a base branch
from
Open

31 ci benchmarking #32

wants to merge 86 commits into from

Conversation

lorenzovarese
Copy link
Collaborator

@lorenzovarese lorenzovarese commented Sep 12, 2024 •
edited by tehrengruber
Loading

  • (GitHub) Fix Documentation CI
  • (GitHub) Fix CI that runs tests
  • (GitHub) Fix benchmark/AirspeedVelocity.jl CI
  • (CSCS) Add script that runs AirspeedVelocity benchmarks between main and the current branch of the PR. Note: the table is only printed in the terminal of the CI job, it is not sent on GitHub

Reminder: we have tried to fix the architecture but the bandwidth numbers seems to be low.

Note: This PR depends on #16

lorenzovarese and others added 30 commits July 18, 2024 16:05
@lorenzovarese
Fix mesh definitions in benchmarks
5c46d04
@lorenzovarese
Attempt to fix the benchmark PR
1eea839
@lorenzovarese
Fix pip install gt4py
02ee8b7
@lorenzovarese
Fix PyCall installation in the benchmark_pr.yml
2ae9b77
@lorenzovarese
Fix the PyCall invoke
8686326
@lorenzovarese
Add reference to julia env in benchmark_pr config
e978b6c
@lorenzovarese
Add cache for python, and fix the pycall (again :/)
ea7d32d
@lorenzovarese
Activate the env in the benchmark CI
3d12f85
@lorenzovarese
Include the Cell and K definitions in the benchmark
2ae25f2
@lorenzovarese
Add readme to run benchmark example
5412e44
@lorenzovarese
Add commented benchmark for field operations
978e6b5
@lorenzovarese
Merge remote-tracking branch 'origin' into 16-setup-benchmarking-infr…
49687ce 
…astructure
@lorenzovarese
fix benchmarks
8046538
@lorenzovarese
Add benchmark comparison between Julia's broadcast addition and the f…
8fea0ca 
…ield operator one
@lorenzovarese
Update the Benchmark suite. Provide comparison between broadcast on a…
8d0296b 
…rray, on fields data and with field operator.
@lorenzovarese
Improve naming and type checking
b9d4e2e
@lorenzovarese
Add draft of neighbour_sum benchmark
2ab1421
@lorenzovarese
Add the benchmarks for sine and cosine field operators
3062bdf
@lorenzovarese
Add benchmarks for remapping
323c269
@lorenzovarese
Add draft mpdata
9c138c2
@lorenzovarese
Merge remote-tracking branch 'origin' into 16-setup-benchmarking-infr…
e3ba8ec 
…astructure
@lorenzovarese
Clear benchmarks.jl and add remapping
700a545
@lorenzovarese
Add neighbor sum benchmark to the suite
3590280
@lorenzovarese
Fix dependencies in benchmarks
0be7ec1
@lorenzovarese
Add verbose flag to avoid printing
62276b0
@lorenzovarese
Quick fix to the unary/binary operation support
1bbb1e6
@lorenzovarese
Use the ExampleMeshes in Atlas miniapp (with workaround on the offset…
17a55f8 
…_provider)
@lorenzovarese
Add benchmark for mp_data
fcb44cd
@lorenzovarese
Fix slicing operation in the advection_miniapp
22d1257
@lorenzovarese
Fix benchmarking size
30d92c1
@lorenzovarese lorenzovarese added the enhancement New feature or request label Sep 12, 2024
@lorenzovarese lorenzovarese self-assigned this Sep 12, 2024
@lorenzovarese
Merge branch '16-setup-benchmarking-infrastructure' into 31-ci-benchm…
0ff763e 
…arking

Merge to provide visibility to ExampleMeshes done in the other branch
but required in the current branch to be used by the benchmarks
@lorenzovarese
Merge branch '31-ci-benchmarking' of https://github.com/GridTools/Gri…
13a8ca2 
…dTools.jl into 31-ci-benchmarking
@lorenzovarese
Add atlas4py dependency into the CI
70a0aa8
@lorenzovarese
Add documentation to access ci container
38f2db7
@lorenzovarese
Add multithread optimization to custom broadcast
f18450d
@lorenzovarese
Merge remote-tracking branch 'origin' into 31-ci-benchmarking
25e9a7c
@lorenzovarese
Fix basic benchmark ci
57772c2
@lorenzovarese
Add atlast4py to the basic ci for benchmarks
b8f6d64
@lorenzovarese
Add atlas4py dependency to documentation ci
47bd242
@lorenzovarese
Improve basic ci
54204f6
@lorenzovarese
Fix benchmark pr basic
329a5f2
@lorenzovarese
Change basic benchmark pr
54fbd7d
@lorenzovarese
Fix commit comparison in benchmark pr basic
01b1188
@lorenzovarese
Fix commit hash in benchmark pr
f1c720f
@lorenzovarese
Add package name to benchpkgplot in benchmark pr
c79c03b
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Benchmark Results

3bd4224... e5dd377... 3bd4224.../e5dd3779b6047c...
addition/array_broadcast_addition 12.2 ± 0.21 ms 12.3 ± 1.4 ms 0.985
addition/field_op_broadcast_addition 17.5 ± 0.47 ms 19.3 ± 0.96 ms 0.905
addition/fields_broadcast_addition 12 ± 0.35 ms 14.2 ± 0.37 ms 0.844
neighbor_sum/field_operator 0.422 ± 0.017 s 0.439 ± 0.0077 s 0.96
remapping/field_operator 0.151 ± 0.0019 s 0.154 ± 0.0042 s 0.983
trigonometry/cos 0.0747 ± 0.00035 s 0.0859 ± 0.00033 s 0.87
trigonometry/field_op_cos 0.0799 ± 0.00038 s 0.0908 ± 0.0007 s 0.88
trigonometry/field_op_sin 0.0768 ± 0.00054 s 0.0863 ± 0.0006 s 0.889
trigonometry/sin 0.0725 ± 0.00039 s 0.0806 ± 0.00033 s 0.9
time_to_load 5.36 ± 0.017 s 5.36 ± 0.042 s 1

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact to this workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehrengruber tehrengruber Awaiting requested review from tehrengruber

Assignees

@lorenzovarese lorenzovarese

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzovarese @tehrengruber