Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Several ROCm Versions #98

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Support for Several ROCm Versions #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc03e94
Support for several ROCm versions
fthaler Oct 22, 2024
d1a4f46
Merge branch 'master' into rocm-versions
fthaler Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ jobs:
strategy:
matrix:
base: [base]
version: ["6.2.2"]
steps:
- uses: actions/checkout@v2
- name: Free Disk Space (Ubuntu)
Expand All @@ -165,17 +166,18 @@ jobs:
docker build
--progress=plain
--cache-from $CR_REPOSITORY:${{ matrix.base }}
--cache-from $CR_REPOSITORY:${{ matrix.base }}-rocm-6.2
--cache-from $CR_REPOSITORY:${{ matrix.base }}-rocm-${{ matrix.version }}
--build-arg BUILDKIT_INLINE_CACHE=1
--tag $CR_REPOSITORY:${{ matrix.base }}-rocm-6.2
--tag $CR_REPOSITORY:${{ matrix.base }}-rocm-${{ matrix.version }}
--build-arg REPOSITORY=$CR_REPOSITORY
--build-arg BASE=${{ matrix.base }}
--build-arg ROCM_VERSION=${{ matrix.version }}
hip
- name: Push
if: ${{ (github.event_name == 'push' || github.event_name == 'workflow_dispatch') && github.repository == 'GridTools/gridtools-docker' }}
run: >
echo ${{ secrets.GITHUB_TOKEN }} | docker login ghcr.io -u $GITHUB_ACTOR --password-stdin &&
docker push $CR_REPOSITORY:${{ matrix.base }}-rocm-6.2 &&
docker push $CR_REPOSITORY:${{ matrix.base }}-rocm-${{ matrix.version }} &&
docker logout ghcr.io

hpx:
Expand Down
16 changes: 10 additions & 6 deletions hip/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,18 @@ ARG BASE
FROM ${REPOSITORY}:${BASE}
LABEL maintainer="Felix Thaler <[email protected]>"

# NOTE: If you change the ROCm version here, also change it in the build.yml to avoid overwriting the old image,
# see https://github.com/GridTools/gridtools-docker/issues/97.
RUN wget https://repo.radeon.com/amdgpu-install/6.2.1/ubuntu/noble/amdgpu-install_6.2.60201-1_all.deb && \
ARG ROCM_VERSION
ENV ROCM_VERSION ${ROCM_VERSION}

# NOTE: the newest ROCm release should allow to also install older releases. However, older releases
# might not necessarily be available on the current Ubuntu version. For example, on Ubuntu 24.04,
# ROCm 6.2 is currently the only available release.
RUN wget https://repo.radeon.com/amdgpu-install/6.2.2/ubuntu/noble/amdgpu-install_6.2.60202-1_all.deb && \
apt-get update -qq && \
DEBIAN_FRONTEND=noninteractive apt-get install -qq -y ./amdgpu-install_6.2.60201-1_all.deb && \
DEBIAN_FRONTEND=noninteractive apt-get install -qq -y ./amdgpu-install_6.2.60202-1_all.deb && \
apt-get update -qq && \
amdgpu-install -y --usecase=rocm,hip --no-dkms && \
amdgpu-install -y --usecase=hiplibsdk --no-dkms --rocmrelease=${ROCM_VERSION} && \
rm -rf /var/lib/apt/lists/*

ENV ROCM_PATH=/opt/rocm
ENV ROCM_PATH=/opt/rocm-${ROCM_VERSION}
ENV PATH=${ROCM_PATH}/bin:${PATH} CXX=${ROCM_PATH}/bin/hipcc
Loading