-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare code for Elixir 1.18 #15
base: master
Are you sure you want to change the base?
Conversation
91013b4
to
0ffa372
Compare
9a36d0d
to
7ae5037
Compare
aea3a84
to
1394fca
Compare
1394fca
to
dac268f
Compare
Hah, I was looking at resolving the type errors yesterday. Got sucked into another issue on a different library. |
Side note, is committing the generated docs useful anymore? 8 years ago it made sense, but now hexdocs is not going anywhere and regenerating them is fairly simple. |
@@ -41,11 +41,13 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
os: ["ubuntu-20.04"] | |||
elixir: ["1.15", "1.14", "1.13"] | |||
elixir: ["1.18", "1.16", "1.15", "1.14", "1.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can drop 1.13
, it was marked end of life https://endoflife.date/elixir
Edit: Same thing with OTP 24 https://endoflife.date/erlang
Looks good. I haven't pored over every detail in this change, but it passes the tests in my PDF generator that uses this as a dependency and eliminates the warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above!
As mentioned in PR opened by @camelpunch, this PR solves that issue while keeping the same spec as the original intention provided by the code base.
I have been reviewing the specification and other libraries (go, zig and javascript), and keeping the
0x2F
(magic byte) is the best way to go, than removing it (approach taken by the mentioned PR).Then, I have added Elixir 1.18 to the CI Test and Lint jobs (version matrix) and added
--warnings-as-errors
inmix compile
.Correcting badges (README) and incorporating 3 new github action workflows as a replacement for Travis.
Finally, bumping versions of all dependencies.
58 Tests and 91.5% Code Coverage