Add field counters to allow you to check if a field was referenced #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenshiemi
previously approved these changes
Apr 29, 2025
| # @mission Infrastructure | ||
| # @team DEx | ||
|
|
||
| require 'logger' |
There was a problem hiding this comment.
Yes, unfortunately there's a requirement from active_record in pre-Rails 7.1 versions :/
| # - Anything with ` {field} = ` (this could be a select, update, delete) | ||
| # - Anything with `, field,` in an INSERT (we need to check the values) | ||
| select_field_query = sql.match(MODEL_FIELDS_PATTERN) | ||
| # debugger if sql.match(/INSERT/) |
There was a problem hiding this comment.
For now it can stay, I do need to clean up the TODO.
Co-authored-by: Emily Chen <[email protected]>
|
@tenshiemi - mind re-approving this one if possible? 😄 |
tenshiemi
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The intent of this PR is to enable field counters and create two helpers:
query_by_fieldandquery_by_field_at_least. When trying to analyze changes to models, we may want to check if there's expected changes by looking for specific fields. In doing so, we can use this to test for changes by using the helpers above:query_by_fieldmatches the changes in fields to the expected changes exactly. If they do not match, the test will fail.query_by_field_at_leastmatches the changes in fields to the expected changes, but only matches the fields the expected changes have mentioned. For example, if fields A and B are changed but we only expect field A to change, if the actual values and the expected values for A are the same, we'll pass this test - regardless of what field B changes have been made, if any.query_by_field_at_least_ignore_notfoundmatches the changes in fields to the expected changes, similarly toquery_by_field_at_least, but when checking for changes to field A, if the expected changes are included in the actual changes but not the same, we will pass this test. For example, if field A is expected to contain the values [1,2] and the actual values are [1,2,3],query_by_field_at_least_ignore_notfoundwill succeed butquery_by_field_at_leastwould fail.