Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new relic to worker and Request Permissions view & HTTPError handler #356

Merged
merged 15 commits into from
Mar 9, 2021

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Mar 9, 2021

Description of change

Add new relic to worker

And

Request Permissions view & HTTPError handler

Issue(s)

@dcmcand dcmcand requested a review from rahearn March 9, 2021 16:08
Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up the double require in worker.js

src/worker.js Outdated
import {} from 'dotenv/config';
import throng from 'throng';
import { logger, auditLogger } from './logger';
import { scanQueue } from './services/scanQueue';
import processFile from './workers/files';

require('newrelic');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something got messed up with the merge and the require is now in here twice.

@dcmcand dcmcand requested a review from rahearn March 9, 2021 16:48
@dcmcand dcmcand merged commit 3a0c3a3 into HHS:main Mar 9, 2021
thewatermethod added a commit that referenced this pull request Jul 27, 2021
* TTA Overview widget initial commit

* Add backend tests

* Deploy to sandbox

* Fix lint error

* Fix frontend lint errors

* Merge main and fix invalid region

* Refactor test

* Add frontend tests

* Add frontend tests

* Styling improvements

* Add region number in caption

* Update mocks in landing tests

* initial scaffold

* merge kw-widget

* resolve merge conflicts

* more rough drafting

* some rearranging and cleanup

* initial build complete

* still need to resolve keyboard nav

* refactor that pesky select

* saving my work

* writing tests

* improving test coverage

* fixed lint errors and changed icon

* resolved some outstanding issues and fixed test coverage

* add missing dependency to useEffect

* resolve linting errors

* remove todo

* resolved bug with stacked date pickers

* remove unused css

* fix bug from merge

* fix lint errors

* front end of overview widget

* add space between label and labelExt in DashboardOverview

* wrote date range picker focus tests

* fix lint error

* adding my test back in

* fix failing test

* fixed test

* register dashboard overview widget

* register dashboard overview widget for real this time

* repurposing already created sql

* saving my work

* set up all regions dropdown

* save work

* saving work

* passing a date to the backend

* handle dates in sequelize

* scaffolding be unit test

* fixed date ranger picker test timing out

* dashboard filters now use same variable name as scopes

* unit test for FE Dashboard Overview

* unit test for BE Dashboard Overview

* unit test for access validation [in progress]

* clean up after finishing tests

* TTAHUB-169: Added backend with unit test.

* fixed appending Start Date to widgets query string

* post merge fix import

* fix reports status in where

* Audit vuln

* re-finalize the backend for overview statistics

* Fix case where data was undefined

* simplify the passing of parameters into the widget

* add test to utils

* fix overview widget test I broke

* numerous changes to get the correct data from dashboardwidget

* investigate test failures and get tests to pass

* all tests finally passing

* install plot.ly and react plot.ly

* register basic graph functionality;
:qp
"

* update open api docs

* removed invalid todo comment

* remove invalid todo comment

* adjusted jest timeout

* save progress

* roughed out front end and backend unit test for bar graph

* Fixes to address invalid data getting to backend

* scaffolding out backend

* backend w/ unit test

* remove react-plot.ly

* more work on styling and formatting front end

* fixed broken unit test

* start of UI

* fixed table headers

* add participants filtering multiselct

* add default choice for date range select

* fixed regions and date range select bug

* fix jumping label

* count only number of in person reports, not duration

* fix failing unit test

* removed console.log blocking circleci

* dependency for redoc added to audit ignore

* remove unused css import, create blank test file

* maybe actually fix unit test

* add additional react scripts deps to audit-ignore

* Added Reason List Widget UI test.

* Fix front end unit test lint errors.

* fix audit vuln

* backend audit vuln

* work on tests

* fixed text in test to account for new behavior

* Increase jest unit test timeout

* added simple reason list test to db overview page.

* resolve merge bug

* remove spacing between cols

* adjust so test would pass

* revise overview per Krys

* Added grid for all items on the Dashboard Overview page.

* improving test coverage

* removed grant filter

* Added reason list date with css also updated unit tests.

* Removed border on dashboard widgets.

* fix failing unit tests after change

* update unit test to better test changes

* get that code coverage up

* quick fix for that date picker wrap

* refactor date time to work

* fixed datetime

* satisfy use effect deps

* add validation behavior to daterangepicker text input

* improve validation

* create tooltip

* change grant filtering

* tool tips working

* Update src/widgets/overview.js

Co-authored-by: kryswisnaskas <[email protected]>

* Update src/widgets/dashboardOverview.js

Co-authored-by: kryswisnaskas <[email protected]>

* deploy to sandbox

Co-authored-by: kryswisnaskas <[email protected]>

* working on test coverage for ar graph

* give this one fe test more time

* adjust tests to pass given changed widget queries

* added test to make branch coverage > 90

* fixed tooltip prop type

* fix post merge bugs

* trying to ensure this test passes

* Fix props for both obj and array.

* comment out oft-failing test

* comment out oft-failing test

* working on increasing test coverage

* copy test from graph branch

* fixed test coverage

* fix duplicate use effect

* test coverage fixes

* Worked with Matt to cleanup Dashboard CSS.

* Added unit test coverage and cleanup.

* Remove screen debug.

* cleanup layout merge

* headings on all the widgets should match

* refactor broke some unit tests

* trying to deploy this on sandbox

* fix lint issue

* switching plot.ly bundles to try and avoid eval()

* refactor to use matching topic list from the frontend

* remove redundant plot.ly package

* finesse where we land and where we dont

* unfinessing

* fix failing date test

* fixed some css based on PR feedback

* fix tooltip placement

* add new topics to bar graph

* removed total grants from overview widget

* fix heading order for accessibility

* refactor and fix css bugs based on feedback

* tweak tablet layout

* fix selection indicator

* add boilerplate for including datearange in button select

* date range select uses button to apply custom range

* remove console statement

* cleanup on the button select

* fixing unit test coverage

* clean up after lint

* added docs

* another successful unit test in the books

* beef up front end unit test

* remove unused code from router

* rename function to match usage

* remove some extraneous commentary

* remove unused parameter

* mobile first dummy

* note in topics to keep things consistent w/ fe&be

* improve mobile breakdown in topics/frequency

* rename topics in topic frequency graph

* added alert when invalid date range seleclted

* good news fewer audit vulnerabilites

* improving error messages, always

* changed dashboard title per patrice feedback

* fix failing unit test

* clean up prop type errors in console

* deploy dashboardto sandbox for review

* reset unit test state

* removed z-index from topics graph select

* attempt to fix css bug present in sandbox

* Merge branch 'TTAHUB167/create-regional-dashboard-page' of https://github.com/adhocteam/Head-Start-TTADP into TTAHUB167/create-regional-dashboard-page

* incorporating feedback from damon and christine

* revise unit test

* put the dashboard behind a feature flag

* make some changes to the Topic graph for clarity

* Fix failing unit test.

* Update frontend/src/widgets/__tests__/TopicFrequencyGraph.js

Co-authored-by: Josh Salisbury <[email protected]>

* TTAHUB-170/Total Number of Hrs and Grantees Graph (#356)

* Placehold WIP.

* WIP.

* unit tests for graph.:

* Fix unit test.

* WIP added Graph for total TTA.

* Total Hrs chart updates for Legend and Tool Tips.

* Added unit test for UI of new line graph.:

* Meet global code coverage.

* Test in sandbox.

* Code clean up per Matts comments.

* Fixes for tool tip issue also other updates and cleanup.

* Fix audit vuln.

* Fix resize of page with charts per Josh comments.

* Fixes for legacy reports with test.

* Appease the linting gods.

* Fix unit test.

* Fixes for legacy reports and for when date range spans more than 1 yr.

* Added chart axis labels per Patrices comments during demo and cleanup.

* Put back date range being passed in req for total tta graph.

* standardize widget heading sizes

* i can make it a string

* add labels to x & y axis on topic/freq graph

* match widget titles to mockup

Co-authored-by: Josh Salisbury <[email protected]>
Co-authored-by: kryswisnaskas <[email protected]>
Co-authored-by: kryswisnaskas <[email protected]>
Co-authored-by: Adam Levin <[email protected]>
Co-authored-by: Adam Levin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request Permissions Page
3 participants