well that actually worked, let's clean it up

HHS · Oct 21, 2024 · bddb276 · bddb276
1 parent d720e0d
commit bddb276
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 28 deletions.
diff --git a/frontend/tests/e2e/search/search-loading.spec.ts b/frontend/tests/e2e/search/search-loading.spec.ts
@@ -6,32 +6,22 @@ import {
 } from "tests/e2e/search/searchSpecUtil";
 
 test.describe("Search page tests", () => {
-  // test.beforeEach(async ({ page }: { page: Page }) => {
-  //   // Navigate to the search page with the feature flag set
-  //   await page.goto("/search?_ff=showSearchV0:true");
-  // });
-
   test("should show and hide loading state", async () => {
+    const searchTerm = generateRandomString([4, 5]);
+    const searchTerm2 = generateRandomString([8]);
+
     const browser = await chromium.launch({ slowMo: 100 });
+
     const page = await browser.newPage();
     await page.goto("/search?_ff=showSearchV0:true");
-    // if this doesn't work we can try https://playwright.dev/docs/api/class-browsertype#browser-type-launch-option-slow-mo
-    const searchTerm = generateRandomString([4, 5]);
     const loadingIndicator = page.getByTestId("loading-message");
-    // await Promise.all([
-    //   fillSearchInputAndSubmit(searchTerm, page),
-    //   expect(loadingIndicator).toBeVisible(),
-    // ]);
 
     await fillSearchInputAndSubmit(searchTerm, page);
     await expect(loadingIndicator).toBeVisible();
     await expect(loadingIndicator).toBeHidden();
 
-    // const searchTerm2 = generateRandomString([8]);
-    // await Promise.all([
-    //   fillSearchInputAndSubmit(searchTerm2, page),
-    //   expect(loadingIndicator).toBeVisible(),
-    // ]);
-    // await expect(loadingIndicator).toBeHidden();
+    await fillSearchInputAndSubmit(searchTerm2, page);
+    await expect(loadingIndicator).toBeVisible();
+    await expect(loadingIndicator).toBeHidden();
   });
 });
diff --git a/frontend/tests/e2e/search/searchSpecUtil.ts b/frontend/tests/e2e/search/searchSpecUtil.ts
@@ -34,17 +34,6 @@ export const generateRandomString = (desiredPattern: number[]) => {
   }, "");
 };
 
-//   let result = "";
-//   const charactersLength = characters.length;
-//   let counter = 0;
-//   while (counter < length) {
-//     result += characters.charAt(Math.floor(Math.random() * charactersLength));
-//     counter += 1;
-//   }
-//   return result;
-// };
-// (Math.random() + 1).toString(36).substring(7);
-
 export function expectURLContainsQueryParam(
   page: Page,
   queryParamName: string,