[Issue 2554] clean up fetcher frontend data fetcher pattern #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
force-pushed
the
dschrashun/2554-cleanup-fetcher
branch
from
a76248a to
a0bcdf8
Compare
emilycnava
reviewed
Oct 25, 2024
frontend/src/app/api/Fetchers.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| import SearchOpportunityAPI from "src/app/api/SearchOpportunityAPI"; | |||
|
|
|||
| import OpportunityListingAPI from "./OpportunityListingAPI"; | |||
There was a problem hiding this comment.
Maybe I"m just not seeing it, but not seeing this file present in this PR?
There was a problem hiding this comment.
that file should be there, but the relative path needs to get cleaned up. You don't see /simpler-grants-gov/frontend/src/app/api/OpportunityListingAPI.ts? It should be there on main as well
acouch
reviewed
Oct 28, 2024
acouch
reviewed
Oct 28, 2024
acouch
reviewed
Oct 28, 2024
acouch
reviewed
Oct 28, 2024
acouch
approved these changes
Oct 28, 2024
doug-s-nava
added a commit
that referenced
this pull request
Oct 30, 2024
* removes the "services/search/searchfetcher" directory and existing "fetcher" pattern * moves any necessary related functionality into the "/api" classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2554
Time to review: 15 mins
Changes proposed
This change removes the
services/search/searchfetcherdirectory, and moves any necessary related functionality into the/apiclasses. For more discussion on reasoning and expectations, refer to the ticketNote that for ease of code change management this is currently branched off of dschrashun/2448-v1-search-endpoint
which has not been merged to main yet. If this PR is approved before feature/frontend-opensearch is approved for merging to main, this will merge into freature/frontend-opensearch. This seems fine as the change isn't urgent but could be rebased off main if we want to get it in.
Context for reviewers
Test steps
Additional information
Follow up todos: