[Issue #2278] Attempting to add another S3 bucket for API usage #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
reviewed
Nov 5, 2024
infra/api/service/s3.tf
Outdated
| @@ -0,0 +1,83 @@ | |||
| resource "aws_s3_bucket" "documents_draft" { | |||
There was a problem hiding this comment.
Suggested change
| resource "aws_s3_bucket" "documents_draft" { | |
| resource "aws_s3_bucket" "draft_documents" { |
small opinion
infra/modules/service/main.tf
Outdated
| @@ -18,6 +18,7 @@ locals { | |||
| { name : "PORT", value : tostring(var.container_port) }, | |||
| { name : "AWS_REGION", value : data.aws_region.current.name }, | |||
| { name : "S3_BUCKET_ARN", value : aws_s3_bucket.general_purpose.arn }, | |||
| { name : "DRAFT_S3_BUCKET_ARN", value : aws_s3_bucket.documents_draft.arn }, | |||
There was a problem hiding this comment.
Move this into infra/api/service/main.tf line 143
Like so:
extra_environment_variables = merge(
local.service_config.extra_environment_variables,
{ "ENVIRONMENT" : var.environment_name },
{ "DRAFT_S3_BUCKET_ARN" : aws_s3_bucket.documents_draft.arn }
)
mdragon
force-pushed
the
mdragon/2278-infra-draft-documents
branch
from
a533db2 to
6031041
Compare
mdragon
force-pushed
the
mdragon/2278-infra-draft-documents
branch
from
40d7655 to
8a15f1d
Compare
mdragon
changed the title
coilysiren
reviewed
Nov 7, 2024
Comment on lines
+12
to
+22
| workflow_dispatch: | ||
| inputs: | ||
| environment: | ||
| description: "target environment" | ||
| required: true | ||
| default: "dev" | ||
| type: choice | ||
| options: | ||
| - dev | ||
| - staging | ||
| - prod |
coilysiren
reviewed
Nov 7, 2024
mdragon
force-pushed
the
mdragon/2278-infra-draft-documents
branch
from
9db8202 to
863d31d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2278
Time to review: 3 mins
Changes proposed
Adding a 2nd bucket to store non-published Documents/Attachments associated with Opportunities.