[Issue 2665] Analytics jobs conditionally use IAM token as Postgres pwd #2799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2665
Time to review: 2 mins
Changes proposed
Adds a switch in
analytics/integrations/db.py
that determines which value to use for a DB password when connecting to Postgres: either the value inlocal.env
or an IAM token, depending on an environment variable.Also adds better exception handling, to make errors easier to spot in CI.
Context for reviewers
This is a follow up to previous PRs, #2786 and #2796, and part of an effort to get
analytics
step functions to successfully connect to Postgres DB in a CI environment.Additional information