Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 2665] Analytics jobs conditionally use IAM token as Postgres pwd #2799

Merged
merged 12 commits into from
Nov 9, 2024

Conversation

DavidDudas-Intuitial
Copy link
Collaborator

@DavidDudas-Intuitial DavidDudas-Intuitial commented Nov 9, 2024

Summary

Fixes #2665

Time to review: 2 mins

Changes proposed

What was added, updated, or removed in this PR.

Adds a switch in analytics/integrations/db.py that determines which value to use for a DB password when connecting to Postgres: either the value in local.env or an IAM token, depending on an environment variable.

Also adds better exception handling, to make errors easier to spot in CI.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

This is a follow up to previous PRs, #2786 and #2796, and part of an effort to get analytics step functions to successfully connect to Postgres DB in a CI environment.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@DavidDudas-Intuitial DavidDudas-Intuitial changed the title [Issue 2665] Analytics jobs connect to db with IAM token [Issue 2665] Analytics jobs conditionally use IAM token as Postgres pwd Nov 9, 2024
@DavidDudas-Intuitial DavidDudas-Intuitial merged commit 56acd6d into main Nov 9, 2024
1 check passed
@DavidDudas-Intuitial DavidDudas-Intuitial deleted the issue-2665-implement-iam branch November 9, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load GitHub data into Postgres in Dev
2 participants